[4.0] Reimplementing client filter in Modules Manager#23406
Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom Jan 6, 2019
Merged
[4.0] Reimplementing client filter in Modules Manager#23406wilsonge merged 6 commits intojoomla:4.0-devfrom
wilsonge merged 6 commits intojoomla:4.0-devfrom
Conversation
Member
|
I have tested this item ✅ successfully on 373e51f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23406. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 373e51f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23406. |
Member
Author
|
rtc. Thanks for testing. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23406. |
Member
Author
Contributor
|
@SniperSister @zero-24 RIPS please. I'm not really sure how this happened as I reran this a second time so reproducible http://ci.joomla.org/joomla/joomla-cms/13420 But all i did was merge in 4.0 🤔 |
Member
Author
|
Looks OK to merge now @wilsonge |
Contributor
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #23400
Summary of Changes
As title says
Testing Instructions
Display Modules Manager
After patch
Client filter now displays.