[4.0] Admin modules: Cannot select or filter by position

[infograf768]

#22263 forgot admin modules

Summary of Changes

Change type of the position field for admin modules.
Setting the correct client id.

Testing Instructions

Install j4 from 4.0-dev or nightly.
Display Administrator Modules Manager
Create or edit one these modules.

Note: there are other errors

Expected result

The Position field should be similar to the one used for Site Modules, i.e. letting clear, select, set to None the position.
Filtering by position should display the administrator template positions

Actual result

For the manager, positions are sometimes the ones from the frontend template in the filter

Editing the admin module displays a simple field

After patch

Note

There are other errors, not only related to admin modules.

1. The calendar icons are showing over the position dropdown (see image above)
2. After filtering in the manager by anything else than Select and clicking anywhere on the page, the filter fields are displayed horizontally on the page, hiding some items.

General Comment

The decision to take off from the Modules Manager the Site/Admin filter is at the origin of some issues concerning userstate and filters specially when a user switches from one to the other via the menu or System CPanel.

@Fedik

[laoneo]

Input shouldn't be modified in a layout file.

[infograf768]

@laoneo
What do you suggest to solve the issue?

[infograf768]

The other solution is to create specific fields for admin modules.
I could not find another way.

[infograf768]

Another solution: doing that in the models.
On it now.

[infograf768]

Done. Please check.

[Fedik]

I think a correct way would be to use a field attribute.
but for this also need to improve ModulesPositioneditField also

[infograf768]

see below

[SharkyKZ]

Is this not the same as #22040? At least the filter part.

[infograf768]

not really as we have a new field and the modulesposition field was modified in 4.0.
see
#22263

[Fedik]

The calendar icons are showing over the position dropdown

that is CSS issue, somewhere, I tried to fix it in https://github.com/joomla/joomla-cms/pull/22263/files#diff-712f8768cba688c1b024f23f9941f51eR4 not sure why it there again

[infograf768]

@SharkyKZ
You are right. Once again one of these aspects of 4.0 which is way behind staging.
What shall we do?
What is the best code?
If it is the one you used for 3.9.0, I can modify this patch, but I also would have to apply the changes from your PR here for all to work OK.

@wilsonge

[infograf768]

@Fedik
If we use the code in 3.9.0 from @SharkyKZ then indeed we just have to modify the way to get the $clientId in ModulesPositioneditField.php by using getUserState('com_modules.modules.client_id', 0, 'int')

Concerning the dropdown z-index, it looks like .choices__list--dropdown in template.css is loaded BEFORE the /media/vendor/choicesjs/css/choices.css and is therefore overriden by that file. (Debug on).

So we get

.choices__list--dropdown {
  display: none;
  z-index: 1;
  position: absolute;
  width: 100%;
  background-color: #FFFFFF;
  border: 1px solid #DDDDDD;
  top: 100%;
  margin-top: -1px;
  border-bottom-left-radius: 2.5px;
  border-bottom-right-radius: 2.5px;
  overflow: hidden;
  word-break: break-all;
}

and z-index = 1; instead of 10

[SharkyKZ]

That should work. Just don't add 3rd argument to getUserState(). I added it by mistake. Oops.

[infograf768]

Modified to use getUserState
Please test.

[ReLater]

I have tested this item ✅ successfully on c4d5e9e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23289.}

[anibalsanchez]

I have tested this item ✅ successfully on 76b957b

Test OK

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23289.}

[infograf768]

RTC. Thanks for testing.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23289.}

[wilsonge]

Thanks guys!