Skip to content

[4.0] No jQuery in the xml files...#23418

Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom
dgrammatiko:4.0-dev-filters
Jan 2, 2019
Merged

[4.0] No jQuery in the xml files...#23418
wilsonge merged 6 commits intojoomla:4.0-devfrom
dgrammatiko:4.0-dev-filters

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Dec 31, 2018

Pull Request for Issue # .

Summary of Changes

  • Added a new method in core.js
  /**
   * Method that resets given inputs and submits the given form
   * @param {HTMLElement}  The element that initiates the call
   */
  Joomla.resetFilters = (element) => { }
  • Changed all the xml filters to use this method
  • The method will reset all the fields of the filters form only except:
    -- the task
    -- the token
    -- the boxcheked

Testing Instructions

Go to Admin templates, check if the site/admin dropdown resets the table options
screenshot 2018-12-31 at 21 53 28

Expected result

Actual result

Documentation Changes Required

Yes.
Basically to implement the filter reset one just needs to add in the XML:

		onchange="Joomla.resetFilters(this)"

That simple

@infograf768
Copy link
Member

Change missing for filter_modulesadmin.xml

@dgrammatiko dgrammatiko changed the title [4.0][WIP] No jQuery in the xml files... [4.0] No jQuery in the xml files... Jan 1, 2019
@wilsonge wilsonge merged commit b51cae0 into joomla:4.0-dev Jan 2, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Jan 2, 2019

Looks good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants