[4.0] Replace chosen.js to choice.js by Fedik · Pull Request #22263 · joomla/joomla-cms

Fedik · 2018-09-19T20:01:06Z

Summary of Changes

This a try to to replace chosen.js to choice.js.

Module position field
Tags field
Category field
Filter fields

@wilsonge is any else field is missed in the list?

Testing:

Module editing: create custom position, search existing positions
Article editing: test Tag field, test category field
Articles filter: test the filter by multiple category, Tag, etc,

Everything should work as before the patch.

Documentation Changes Required

maybe

Conflicts: administrator/components/com_modules/tmpl/module/edit_positions.php

brianteeman · 2018-09-19T20:23:35Z

ooh getting excited - on my to do list for tomorrow

brianteeman · 2018-09-20T11:44:16Z

administrator/components/com_modules/forms/module.xml

-			type="moduleposition"
+		<field
+			name="position"
+			type="ModulesPosition"


didnt we have an issue with case in the xml files before?

it because class autoloader,
if I keep modulesposition it will try to search for ModulespositionField.php but actual file name is ModulesPositionField.php

yes, there was an issue about it, but cannot find

brianteeman · 2018-09-20T15:30:36Z

build/build-modules-js/settings.json

        "licenseFilename": "LICENSE"
      },
+      "choices.js": {
+        "name": "choices.js",


This need to be changed to just choices otherwise you get this error in the build

Error: ENOENT: no such file or directory, open 'C:\htdocs\40\media\vendor\choices.min.js\css\choices.css'

That what I am had afraid of. Currently I am working with "dev" mode and on on Linux, so all works fine.
The problem that the package name is choices.js https://github.com/jshjohnson/Choices/blob/master/package.json

This will be need to find a solution.

So the problem is with our build scripts and need to be solved there or it will happen again with another package (I'm still new to npm)

You should be ok changing the name on this line to choices. The key on line 124 is the path to the node_modules dir

The key on line 124 is the path to the node_modules dir

@wilsonge well, no, I thought the same, I tried, and that not work.
but I think it is fine not keep an original name,
just have to find out why an Install task fail on Windows

I think I have fixed Error: ENOENT: no such file or directory,, there was incorrect replacing of the file extension.
But @brianteeman said there now some empty CSS file, after build, and I do not have a windows to check in details.

I have looked in my windows but there only a trees 😄

Well that definitely still builds ok and drops the .js in the folder path. I don't have windows either and Rowan who's my go to is on holiday at the moment. @brianteeman can I try sorting out a screenshare with you at some point this week after work?

hm, okay, then I missed something 😃

@wilsonge of course just name a time/date

@wilsonge @Fedik the name part in the json is supposed to set a custom name for the vendor. IIRC there are couple of crappy names in the dependencies with @ or other strange .something parts in the names. If the code is not doing what is supposed to do just blame it on me but fwiw it was implemented based on some specific cases...

I have renamed to choicesjs

Quy · 2018-09-20T18:10:51Z

administrator/components/com_categories/layouts/joomla/form/field/categoryedit.php

+$attr .= $required ? ' required' : '';
+$attr .= $autofocus ? ' autofocus' : '';
+
+// To avoid user's confusion, readonly="true" should imply disabled="true".


Change to disabled="disabled"?

Quy · 2018-09-20T18:11:42Z

administrator/components/com_categories/layouts/joomla/form/field/categoryedit.php

+?>
+
+<joomla-field-categoryedit><?php
+	echo implode($html);


Make it one line <?php echo implode($html); ?>

you are looking in wrong commit 😃

Quy · 2018-09-20T18:12:01Z

administrator/components/com_categories/layouts/joomla/form/field/categoryedit.php

+
+Text::script('JGLOBAL_SELECT_NO_RESULTS_MATCH');
+Text::script('JGLOBAL_SELECT_PRESS_TO_SELECT');
+//Text::script('JGLOBAL_TYPE_OR_SELECT_SOME_OPTIONS');


Delete comment?

it not finished, anything can happen

### The problem when running the scripts with joomla#22263 they were trying to process the choices css files as if they were js. this was only present on windows ### The solution?? hopefully this is correct. It works for me but anything with regex and js and I am stabbing in the dark

brianteeman · 2018-10-18T16:54:22Z

see #22706 for the corrected(?) build script

### The problem when running the scripts with #22263 they were trying to process the choices css files as if they were js. this was only present on windows ### The solution?? hopefully this is correct. It works for me but anything with regex and js and I am stabbing in the dark

Fedik · 2018-10-19T08:59:39Z

I will check this weekend, also the conflicts

brianteeman · 2018-10-19T09:19:53Z

I "think" the error is related to the calendar field

Conflicts: administrator/components/com_categories/Field/CategoryeditField.php administrator/components/com_modules/tmpl/module/edit_positions.php build/build-modules-js/update.js

Fedik · 2018-10-19T16:08:27Z

I am getting this error when opening an article with some fields

@brianteeman please tell me which field types do you have in that article?

Fedik · 2018-10-19T16:15:08Z

@laoneo do you remember what this thing is doing?

joomla-cms/administrator/components/com_fields/Helper/FieldsHelper.php

Lines 314 to 316 in 0e641a3

    
           $xml = new \DOMDocument; 
        
           $xml->loadHTML($formField->__get('input')); 
        
           $options = $xml->getElementsByTagName('option');

the warning because DOMDocument not know about a custom tags, hm

brianteeman · 2018-10-19T18:01:56Z

There were two fields. Calendar and text

Fedik · 2018-10-20T11:52:52Z

@brianteeman should work now

HLeithner · 2018-10-20T12:05:31Z

administrator/components/com_fields/Helper/FieldsHelper.php

 			// Choose the first category available
 			$xml = new \DOMDocument;
+			libxml_use_internal_errors(true);
 			$xml->loadHTML($formField->__get('input'));


Sry if its already answered but what happens here that this hack is needed?

see #22263 (comment)

DOMDocument shows a warning on unknown elements such as html5 and custom elements

brianteeman · 2018-10-21T17:04:32Z

@Fedik yes that problem has been resolved - thanks

wilsonge · 2018-10-24T17:55:47Z

So just to be clear is this PR now working (with a bit of a grim hack to the DomDocument stuff?)

Fedik · 2018-10-24T19:31:54Z

for me, working :)

wilsonge · 2018-11-11T14:45:40Z

Thankyou for this!

infograf768 · 2018-12-18T08:28:23Z

As stated in #23289, choices.css is loaded after template.css, therefore overriding specific overrides in template.css

Fedik added 7 commits September 17, 2018 20:44

add choice-js

3d27f73

FieldModuelEditposition custom element

9bbd1d1

FieldModuelEditposition translation

3232476

FieldModuelEditposition extend FormField is enough

cf59eb5

Sync. Merge branch '4.0-dev' into choice-js

347beb0

Conflicts: administrator/components/com_modules/tmpl/module/edit_positions.php

field-tags

d563647

field-tags make custom term to work

29106a0

Fedik requested a review from brianteeman as a code owner September 19, 2018 20:01

joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Sep 19, 2018

Fedik mentioned this pull request Sep 19, 2018

[4.0] Remove most chosen hacks #22208

Merged

brianteeman reviewed Sep 20, 2018

View reviewed changes

Fedik added 5 commits September 20, 2018 16:23

FieldModuleEditposition: fix typoe and cs

38ad7b8

FieldModuleEditposition: remove unused stuff

7101db5

field-tags request for remote tags

195f97c

field-tags deprecate some stuff

b187d5c

Merge branch 'choice-js-tags' into choice-js

74e0a49

brianteeman reviewed Sep 20, 2018

View reviewed changes

Fedik added 2 commits September 20, 2018 19:14

choice-js-cat categoriedit field

ea011be

choice-js-cat categoriedit make it work

6f4630d

Quy reviewed Sep 20, 2018

View reviewed changes

Fedik added 6 commits September 20, 2018 21:49

merge JS to single field

b57715e

prevent from submit on "enter"

b0ce929

add some extar info

8756b4f

add layout to ListField

87e3dd3

joomla.form.field.list-fancy-select layout for list field

da9e886

joomla.form.field.accesslevel for accesslevel field

457bb4d

brianteeman mentioned this pull request Oct 18, 2018

[4.0] Update build script #22706

Merged

Sync. Merge branch '4.0-dev' into choice-js

0e641a3

Conflicts: administrator/components/com_categories/Field/CategoryeditField.php administrator/components/com_modules/tmpl/module/edit_positions.php build/build-modules-js/update.js

Fedik added 3 commits October 20, 2018 13:57

DOMDocument::loadHTML and CE

7fb603c

choices.js and WebAsset

5f4b99c

get/set value, and required validation

538f7b9

HLeithner reviewed Oct 20, 2018

View reviewed changes

wilsonge merged commit 141a5e3 into joomla:4.0-dev Nov 11, 2018

wilsonge added this to the Joomla 4.0 milestone Nov 11, 2018

Fedik deleted the choice-js branch November 11, 2018 20:13

infograf768 mentioned this pull request Dec 16, 2018

[4.0] Admin modules: Cannot select or filter by position #23289

Merged

Fedik mentioned this pull request Dec 31, 2018

[4.0] WebAsset allow to set a custom weight when it possible, and speed up checking for new files #23415

Closed

dgrammatiko mentioned this pull request Jan 2, 2019

[4.0] Fixing lots of issues in Tags component and grouping toolbar buttons #23402

Merged

This was referenced Jan 5, 2019

J4.0 - resizing screen makes module positions menu disappear #23448

Closed

J4.0 - module positions partially hidden by publishing calendars #23449

Closed

wilsonge mentioned this pull request Nov 26, 2020

[4.0] Prefill tags with most used items #31481

Merged

roland-d mentioned this pull request Aug 15, 2022

[4.2] hotkeys #38334

Merged

Uh oh!

Comments

Conversation

Fedik commented Sep 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing:

Documentation Changes Required

Uh oh!

brianteeman commented Sep 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fedik Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilsonge Sep 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fedik Sep 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilsonge Sep 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Oct 18, 2018

Uh oh!

Fedik commented Oct 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Oct 19, 2018

Uh oh!

Fedik commented Oct 19, 2018

Uh oh!

Fedik commented Oct 19, 2018

Uh oh!

brianteeman commented Oct 19, 2018

Uh oh!

Fedik commented Oct 20, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Oct 21, 2018

Uh oh!

wilsonge commented Oct 24, 2018

Uh oh!

Fedik commented Sep 19, 2018 •

edited

Loading

Fedik Sep 20, 2018 •

edited

Loading

wilsonge Sep 23, 2018 •

edited

Loading

Fedik Sep 23, 2018 •

edited

Loading

wilsonge Sep 23, 2018 •

edited

Loading

Fedik commented Oct 19, 2018 •

edited

Loading