[4.0] Improve DebugBar: view history, allow debug POST and non HTML requests, replace json storage to own #22327
+216
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drone failure 'InstallCest: Configure joomla' seems not related to current PR |
|
I have tested this item ✅ successfully on 0e51812 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22327. |
elkuku
reviewed
Sep 24, 2018
| public function find(array $filters = array(), $max = 20, $offset = 0) | ||
| { | ||
| // Loop through all .php files and remember the modified time and id. | ||
| $files = array(); |
There was a problem hiding this comment.
I guess we can use short array syntax here?
Edit: also above and below...
There was a problem hiding this comment.
it just a copy paste from original FileStorage, but okay
plugins/system/debug/debug.php
Outdated
| return; | ||
| } | ||
|
|
||
| if ('com_content' === $this->app->input->get('option') && 'debug' === $this->app->input->get('view')) |
There was a problem hiding this comment.
Can you just remove this whole if statement please. I don't think that we will add a view to com_content - ever..
There was a problem hiding this comment.
okay, I thought it already something on the way 😄
|
wow |
|
I have tested this item ✅ successfully on 0e51812 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22327. |
Quy
reviewed
Sep 24, 2018
| $dataStr = file_get_contents($this->makeFilename($id)); | ||
| $dataStr = str_replace('<?php die(); ?>#(^-^)#', '', $dataStr); | ||
|
|
||
| return json_decode($dataStr, true) ?: array(); |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The patch add possibility to view a Debug log, by use of DebugBar\OpenHandler.
It allows to debug POST (when #20677 will be merged to 4.0-dev) and non HTML request., and view of debug history.
Also I have changed default '.json' storage to '.php', wich is more secure.
Testing Instructions
Apply path, enable debug. Visit a couple pages on a site.
Open debug bar, you should be able to see a little folder icon.
Click on that folder and you will see Debug history per page.
Ping @elkuku
Reference to DebugBar pr #20380