Skip to content

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Apr 3, 2022

Summary of Changes

This enable Debug plugin to collect data while post request (save, cancel tasks, etc).
This was introduced a couple years ago #22327, but broken somwhere in the midle of 4.0 development (due to some refactoring in Application classes).

Testing Instructions

Apply patch, enable debug.
Try to edit any article, save, cancel etc.
Then open debug bar "history viewer"
image

Actual result BEFORE applying this Pull Request

In history you can see and select only GET requests.

Expected result AFTER applying this Pull Request

In history you can see and select GET and POST requests.
image

Documentation Changes Required

none

@richard67
Copy link
Member

I have tested this item ✅ successfully on c77d011


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37465.

@toivo
Copy link
Contributor

toivo commented Apr 5, 2022

I have tested this item ✅ successfully on c77d011

Tested successfully in Joomla 4.1.3-dev of 4 April in Wampserver 3.2.7 using PHP 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37465.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37465.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 5, 2022
@chmst chmst added this to the Joomla 4.1.3 milestone Apr 5, 2022
'onAjaxDebug' => 'onAjaxDebug',
'onBeforeRespond' => 'onBeforeRespond',
'onAfterRespond' => 'onAfterRespond',
ApplicationEvents::AFTER_RESPOND => 'onAfterRespond',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't this two lines identical?

Copy link
Member Author

@Fedik Fedik Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, and that the issue, should be somehow fixed in J5, I guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Application class trigger diferent AfterRespond event for normal request, and for redirect (that usualy happen after POST)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chmst
Copy link
Contributor

chmst commented Apr 6, 2022

Tested after latest changes. It is still RTC and can be merged when tests are ok.

@laoneo laoneo merged commit 126ed6a into joomla:4.1-dev Apr 6, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 6, 2022
@laoneo
Copy link
Member

laoneo commented Apr 6, 2022

Thanks!!

@Fedik Fedik deleted the fix-debug-post2 branch April 6, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants