Skip to content

Conversation

@csthomas
Copy link
Contributor

@csthomas csthomas commented Jun 6, 2018

Summary of Changes

Add missing triggers before and after send redirection headers.

Testing Instructions

Code review.

Expected result

The onBeforeRespond and onAfterRespond events should be triggered during redirection in the same way that they are triggered when delivering the page.

Actual result

The onBeforeRespond and onAfterRespond events are not triggered during redirection.

@Fedik
Copy link
Member

Fedik commented Sep 15, 2018

I have tested this item ✅ successfully on 881054f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20677.

@Fedik
Copy link
Member

Fedik commented Sep 15, 2018

is it will go to Joomla4 ?

@csthomas
Copy link
Contributor Author

First, this PR must be tested by one more person.

@Quy
Copy link
Contributor

Quy commented Sep 20, 2018

I have tested this item ✅ successfully on 881054f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20677.

@Quy
Copy link
Contributor

Quy commented Sep 20, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20677.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 20, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 22, 2018
@csthomas csthomas deleted the redirect_with_response_event branch September 22, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants