Conversation
In the past there were some issues with folders with a . in them. I forget what the issue was. As a result choices.js was stored in choicesjs to avoid this. This pr does the same for hotkeys.js
Member
|
I have tested this item ✅ successfully on 5eea7ef This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38334. |
Contributor
|
I have tested this item ✅ successfully on 63987b3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38334. |
Contributor
Author
|
This PR will be closed in 24 hours. There is no point in it existing once 4.2 is released. Just dont say no one knew the folder name was a problem and you have to write a complex pr to fix the mess |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38334. |
Contributor
|
Thank you. The issue with a dot is described here: #22263 (comment) |
Contributor
Author
|
well at least it got merged in the end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past there were some issues with folders with a . in them. I forget what the issue was. As a result choices.js was stored in choicesjs to avoid this.
This pr does the same for hotkeys.js
@fancyFranci