Skip to content

Comments

[4.2] hotkeys#38334

Merged
roland-d merged 4 commits intojoomla:4.2-devfrom
brianteeman:hotekys
Aug 15, 2022
Merged

[4.2] hotkeys#38334
roland-d merged 4 commits intojoomla:4.2-devfrom
brianteeman:hotekys

Conversation

@brianteeman
Copy link
Contributor

In the past there were some issues with folders with a . in them. I forget what the issue was. As a result choices.js was stored in choicesjs to avoid this.

This pr does the same for hotkeys.js

@fancyFranci

In the past there were some issues with folders with a . in them. I forget what the issue was. As a result choices.js was stored in choicesjs to avoid this.

This pr does the same for hotkeys.js
@Fedik
Copy link
Member

Fedik commented Jul 30, 2022

I have tested this item ✅ successfully on 5eea7ef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38334.

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 63987b3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38334.

@brianteeman
Copy link
Contributor Author

This PR will be closed in 24 hours. There is no point in it existing once 4.2 is released. Just dont say no one knew the folder name was a problem and you have to write a complex pr to fix the mess

@Quy
Copy link
Contributor

Quy commented Aug 15, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38334.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 15, 2022
@roland-d roland-d merged commit ab6d2f8 into joomla:4.2-dev Aug 15, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 15, 2022
@roland-d
Copy link
Contributor

Thank you. The issue with a dot is described here: #22263 (comment)

@roland-d roland-d added this to the Joomla! 4.2.0 milestone Aug 15, 2022
@brianteeman
Copy link
Contributor Author

well at least it got merged in the end

@brianteeman brianteeman deleted the hotekys branch August 15, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants