-
-
Couldn't load subscription status.
- Fork 3.7k
Implement component params for fieldgroups #17317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement component params for fieldgroups #17317
Conversation
|
Needs the install SQL but seems fine to me. If this can get tested today and tomorrow don't see any reason not to merge. |
|
grrr, adding the install sql, I was sure I have forgotten something but couldn't figure out what :-) |
|
Looks good for me. Everything works |
|
Should the update files not contain 3.8.0 as version number and end with a new line? |
|
Ofc, they should :-)
…--
Viele Grüße/ Best Regards
Robert
Am 28. Juli 2017 um 21:51:02, Allon Moritz ([email protected]) schrieb:
Should the update files not contain 3.8.0 as version number and end with a new line?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I tried this on com_content and can't show the new field. |
|
@infograf768 change item.xml to article.xml . |
|
Got it and I do get a new Option tab when editing a fieldgroup. But what can be the use of other Options in the fieldgroup itself? Any example that makes sense? |
|
I have tested this item ✅ successfully on 298ffab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17317. |
|
RTC as it works as intended. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17317. |
|
@mbabker |
|
Think about a component where you have different fieldgroups, any of them should work a little bit different. With having the ability to add fields to the formgroup you can save the information how they should behave. Then you have to pick up the information in your overwrite/component and act accordingly. |
|
Thanks all who have been worked on this :-) |
* staging: (35 commits) Add filter by Tag to mod_article_category (joomla#16945) Change links Implement component params for fieldgroups (joomla#17317) Moved JLanguageMultilang::isAdminEnabled() to JModuleHelper::isAdminMultilang() (joomla#17314) Fix tests Namespace sodium cipher, use compat API Fix namespace use and class casing Various doc block fixes and removing unneeded imports Class mappings for internal classes that apparently aren't internal Don't load unexisting paths Cleanup and optimization in FinderIndexerDrivers (joomla#13511) Fix deleted files listing Deleted files updated Rename the document renderer base class Split feed data object classes to separate files Correct class name logic Deleted files for joomla#17278 Namespace feed (joomla#17278) [CS] Required=true (joomla#17313) required = false is nnot required (joomla#17309) ...
Summary of Changes
This is pretty much the same as #15915 but only for field groups.
Com_categories has a nice little feature which allows the component developer to place a form file on /administrator/components/com_foo/models/forms/category.xml which get loaded when editing a category.
This pr introduces the same functionality for com_fields. If a file is found on the location /administrator/components/com_foo/models/forms/fieldgroup/item.xml then this file get loaded when the entity com_foo.bar is edited.
You have to name the fields params
Testing Instructions
Put the xml in a component with custom fields support into
/administrator/components/com_foo/models/forms/fieldgroup/item.xml
Item is the section, check https://docs.joomla.org/J3.x:Adding_custom_fields/Implement_into_your_component for details
Expected result
You should see a new tab Options in your fieldgroup edit form
Documentation Changes Required
Would be nice to have that feature documented.