[com_fields] Support to include component specific form files #15915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2017
|
I like this proposal, I'm only not so sure about the location where the file is placed. |
|
When you have many entities, then the forms folder get cluttered with too many files. Thats why I recommend to put it into a subfolder. |
|
I have tested this item ✅ successfully on bf40057 Can do the same also for Contact fields (Mail) ? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15915. |
|
@AlexRed I can do it, when this one got merged. It will be then only one file to add. |
|
I have tested this item ✅ successfully on bf40057 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15915. |
|
RTC after two successful tests. |
joomla-cms-bot
added
PR-staging
and removed
RTC
wojsmol
added a commit
to wojsmol/joomla-cms
that referenced
this pull request
May 10, 2017
zero-24
pushed a commit
that referenced
this pull request
May 10, 2017
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
May 16, 2017
…#15915) * Support to include component specific form files * Hide the display param for users
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Com_categories has a nice little feature which allows the component developer to place a form file on
/administrator/components/com_foo/models/forms/category.xmlwhich get loaded when editing a category.This pr introduces the same functionality for com_fields. If a file is found on the location
/administrator/components/com_foo/models/forms/fields/bar.xmlthen this file get loaded when the entity com_foo.bar is edited.Additionally an overwrite is added which hides the "Automatic Display" field for com_users as it is not relevant for that component.
It should fix #14377 and #15244.
Testing Instructions
Create a new User custom field.
Expected result
The "Automatic Display" field in options is not displayed.
Actual result
The "Automatic Display" field in options is displayed.
Documentation Changes Required
Would be nice to have that feature documented.