required = false is not required #17309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like some commits included this in the xml definition fr a field when it is not needed (and doesnt do anything). You can confirm this by checking the markup of the content rights field in the article edit form before and after the PR - there will be no change
C-Lodder
approved these changes
Jul 28, 2017
|
Thanks for the super quick merge |
izharaazmi
added a commit
to izharaazmi/joomla-cms
that referenced
this pull request
Jul 29, 2017
* staging: (35 commits) Add filter by Tag to mod_article_category (joomla#16945) Change links Implement component params for fieldgroups (joomla#17317) Moved JLanguageMultilang::isAdminEnabled() to JModuleHelper::isAdminMultilang() (joomla#17314) Fix tests Namespace sodium cipher, use compat API Fix namespace use and class casing Various doc block fixes and removing unneeded imports Class mappings for internal classes that apparently aren't internal Don't load unexisting paths Cleanup and optimization in FinderIndexerDrivers (joomla#13511) Fix deleted files listing Deleted files updated Rename the document renderer base class Split feed data object classes to separate files Correct class name logic Deleted files for joomla#17278 Namespace feed (joomla#17278) [CS] Required=true (joomla#17313) required = false is nnot required (joomla#17309) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like some commits included this in the xml definition fr a field when it is not needed (and doesnt do anything).
You can confirm this by checking the markup of the content rights field in the article edit form before and after the PR - there will be no change