[com_templates] - support for scss,sass source formats on joomla update #12727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| $params = json_decode($params, true); | ||
| $sourceformats = explode(',', $params['source_formats']); |
There was a problem hiding this comment.
you probably could replace all above code by just:
$sourceFormats = explode(',', JComponentHelper::getParams('com_templates')->get('source_formats', 'txt,less,ini,xml,js,php,css,scss,sass'));not sure how explode will react if the is no , in source_formats param value tough
|
I actually think this is wrong. If people want to retrospectively add this they can. But imho we shouldn't be changing this for them (ditto for the media manager params) |
|
The other thing is looking at this, if someone removed these items from their configuration, an update would restore them. So there probably isn't a good way to do this even if we wanted to. |
|
closing as is too late for doing it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #10186 .
Summary of Changes
added support support for scss,sass source formats on update
see #12712 for more info