Skip to content

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Nov 2, 2016

Pull Request for Issue #10186 .

Summary of Changes

added sql for #10186 (comment)

support for scss,sass source formats
support for scss,sass source formats
support for scss,sass source formats
support for scss,sass source formats
support for scss,sass source formats
support for scss,sass source formats
@alikon alikon changed the title support for scss,sass source formats sql - support for scss,sass source formats Nov 2, 2016
@zero-24
Copy link
Contributor

zero-24 commented Nov 2, 2016

We need to revert the update part as it would overwrite the current settings by the site owners.

@mbabker
Copy link
Contributor

mbabker commented Nov 2, 2016

This overwrites the entire component parameters. Not sure that's a good idea...

@zero-24
Copy link
Contributor

zero-24 commented Nov 2, 2016

@mbabker we just need to revert the update part the install part is correct ;) or do i miss something?

@mbabker
Copy link
Contributor

mbabker commented Nov 2, 2016

If you want to add the values during the update, it can't be a full replacement of the parameters column like it is now. If you choose not to add the values then just removing the update SQLs is fine.

@C-Lodder
Copy link
Member

C-Lodder commented Nov 2, 2016

Won't the updating part need to be done in administrator\components\com_admin\script.php?

@zero-24 - It will also need to be done in an update, as well as new installation.

@alikon
Copy link
Contributor Author

alikon commented Nov 2, 2016

lets'go only with install for now , the full update of the param field as noticed was a really bad idea

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 4edd94d

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12712.

@C-Lodder
Copy link
Member

C-Lodder commented Nov 2, 2016

I have tested this item ✅ successfully on 4edd94d

I do hope the update side of things isn't forgotten about though


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12712.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Nov 2, 2016
@zero-24 zero-24 merged commit f40c7b7 into joomla:staging Nov 2, 2016
@alikon
Copy link
Contributor Author

alikon commented Nov 2, 2016

i'm thinking something about this update query:

UPDATE params = 
        replace(params,'"source_formats":"','"source_formats":"scss,sass,')
  FROM #__extensions
where extension_id =20;`

what do you think?

@zero-24
Copy link
Contributor

zero-24 commented Nov 2, 2016

Thanks!

@alikon
Copy link
Contributor Author

alikon commented Nov 3, 2016

@C-Lodder not forgotten please test/comment #12727

nvyush pushed a commit to nvyush/joomla-cms that referenced this pull request Nov 9, 2016
* support for scss,sass source formats

joomla#10186 (comment)

* support for scss,sass source formats

* support for scss,sass source formats 

support for scss,sass source formats

* support for scss,sass source formats 

support for scss,sass source formats

* support for scss,sass source formats 

support for scss,sass source formats

* support for scss,sass source formats 

support for scss,sass source formats

* support for scss,sass source formats 

support for scss,sass source formats

* support for scss,sass source formats 

support for scss,sass source formats

* remove the full param update

* remove the full param update

* remove the full param update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants