-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
sql - support for scss,sass source formats #12712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
support for scss,sass source formats
support for scss,sass source formats
support for scss,sass source formats
support for scss,sass source formats
support for scss,sass source formats
support for scss,sass source formats
|
We need to revert the update part as it would overwrite the current settings by the site owners. |
|
This overwrites the entire component parameters. Not sure that's a good idea... |
|
@mbabker we just need to revert the update part the install part is correct ;) or do i miss something? |
|
If you want to add the values during the update, it can't be a full replacement of the parameters column like it is now. If you choose not to add the values then just removing the update SQLs is fine. |
|
Won't the updating part need to be done in @zero-24 - It will also need to be done in an update, as well as new installation. |
|
lets'go only with install for now , the full update of the param field as noticed was a really bad idea |
|
I have tested this item ✅ successfully on 4edd94d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12712. |
|
I have tested this item ✅ successfully on 4edd94d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12712. |
|
i'm thinking something about this update query: UPDATE params =
replace(params,'"source_formats":"','"source_formats":"scss,sass,')
FROM #__extensions
where extension_id =20;`
what do you think? |
|
Thanks! |
* support for scss,sass source formats joomla#10186 (comment) * support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * remove the full param update * remove the full param update * remove the full param update
Pull Request for Issue #10186 .
Summary of Changes
added sql for #10186 (comment)