-
-
Couldn't load subscription status.
- Fork 3.7k
Add basic support for sass/scss files to Template manager editing (redo) #10186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@brianteeman i have just send you a PR for travis i will try to test this evening. |
make travis happy for #10186
|
travis still not happy |
|
travis is happy now |
|
I have tested this item ✅ successfully on 8f74e98 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10186. |
|
Moving to RTC as it was already tested before the redo for merge conflicts This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10186. |
|
The SQL files also need updating too.
replace with:
Unless this is done, people will manually need to go to the Template Options and manually add them. Add a |
|
Correct for 3.x we need to do this as we cant and should not override the entry in the database that maybe has ben changed to something different. |
|
Ahhh ok i got you point now. I'm on a PR :) |
|
@zero-24 maybe this time more fast than you... bored on train.... |
|
Thanks 👍 |
* support for scss,sass source formats #10186 (comment) * support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * remove the full param update * remove the full param update * remove the full param update
* support for scss,sass source formats joomla#10186 (comment) * support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * support for scss,sass source formats support for scss,sass source formats * remove the full param update * remove the full param update * remove the full param update
Redo to resolve merge conflicts in #9871
@zero-24 can you retest this please to make sure I didnt miss anything in this redo