[blog-sample-data] Changes on banner text on the Homepage#227
[blog-sample-data] Changes on banner text on the Homepage#227richard67 merged 20 commits intodevelopmentfrom
Conversation
More contrasting colour for on the banner
|
Personal opinion I am not in favour of styling text as a button. Users think the button is broken ;) |
|
We have put much effort in making colours fit together, the cyan colour breaks it. It doesn’t fit at all to the template colours. |
|
I suggest to make the separator white and the button have white background and the same dark blue text colors as we have elsewhere e.g. for links. The button should lead to some page which makes sense, and this should not be the current page like it is now without this PR in the development branch. If that is technically not possible with reasonable effort, I suggest to remove that button completely. |
|
With the old text "Learn more" for the button, I would have expected to go to a page where I can learn something more about Joomla 4 or the Cassiopeia template. This could have been an internal link or an external link to docs or help pages. With the new text "Enjoy!" I would at least expect something to happen. Ideally it would be an internal link to some page where you can start to do something, e.g. the Author or Admin login or how we called it now, or some page of the sample layouts where you can see something new or special for J4, or whatever else, and if it is just a modal being shown with a longer text "Have fun exploring Joomla 4 with the Cassiopeia template. Just check the menu at the top to find new fancy things" or whatever else. But there should be some kind of action when clicking on a button, not just nothing. |
|
Hmm, I see, the colours come from our Bootstrap 4 colours for the button types, info, success, primary or whatever else we have. Maybe we have to adjust these colours to the template colouring? @drmenzelit What do you think? Or do you like the cyan, and it's just me thinking it doesn't fit? |
|
We could need a designer that adapt the colours for info, success, etc. to fit better to the template... |
|
Thank you for your opinion. So at least we have started a decision process. I make this as draft. The colour comes from template variables - yes, it would be nice to have a designer who defines a good colour scheme for all colour variables. And yes, the button originally should lead to a page with more information. We have not many articles - mainly because it is a challenge for translators. |
…ia into cassiopeia-banner-change
…ia into cassiopeia-banner-change
…ia into cassiopeia-banner-change
|
Reverted colour changes but added a new article typography. |
richard67
left a comment
There was a problem hiding this comment.
Code review ok, real test will follow.
|
|
The colour warning for text on a white background has not sufficient contrast-ratio and should not be used. I am or sure if it is good to show different text clours at all. |
|
I have tested this PR ✅ with success. |
|
I have tested this PR ✅ with success. |
|
Thanks! |
|
Thank you! |
Summary of Changes
A new article for typogrphy has been added to blog sample data.
The call-to-action button "Learn more" leads nowhere until now, it now goes to typography
The link to typography also has been added to the blog sample menu.
Testing Instructions
Install the blog sample data.
Expected result
A Linkt to typography in the top menu,
A link to the article typography on the banner area.
The article typography shows - depending on the chosen fonts, a collection of headings colours and classes