This repository was archived by the owner on Jan 25, 2021. It is now read-only.
Fix SCSS linter error unexpected named color "white"#238
Merged
richard67 merged 1 commit intodevelopmentfrom Nov 15, 2020
Merged
Fix SCSS linter error unexpected named color "white"#238richard67 merged 1 commit intodevelopmentfrom
richard67 merged 1 commit intodevelopmentfrom
Conversation
chmst
approved these changes
Nov 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Fixes error
Unexpected named color "white"reported by the SCSS linter for thetemplates/cassiopeia/scss/blocks/_banner.scssfile.The error was introduced with PR #227 .
Testing Instructions
Code review and test if the separator line in the banner is still white.
Run
node ./node_modules/stylelint/bin/stylelint.js --config build/.stylelintrc.json -s scss "templates/**/*.scss".Actual result BEFORE applying this Pull Request
The separator line in the banner is white.
The linter report an
Unexpected named color "white"error for filetemplates/cassiopeia/scss/blocks/_banner.scss.Expected result AFTER applying this Pull Request
The separator line in the banner is still white.
The linter doesn't report the
Unexpected named color "white"error for filetemplates/cassiopeia/scss/blocks/_banner.scss.Documentation Changes Required
None.