Skip to content
This repository was archived by the owner on Jan 25, 2021. It is now read-only.

Replace template_thumbnail for cassiopeia#226

Merged
richard67 merged 7 commits intodevelopmentfrom
template-thumbnail
Nov 15, 2020
Merged

Replace template_thumbnail for cassiopeia#226
richard67 merged 7 commits intodevelopmentfrom
template-thumbnail

Conversation

@chmst
Copy link
Collaborator

@chmst chmst commented Nov 8, 2020

Pull Request for Issue #174 .

Summary of Changes

A new screen of the new cassiopeia layout

Testing Instructions

Apply the patch and see the template in the backend
grafik

with Preview
grafik

Expected result

Actual result

Tumbnail of the first version of cassiopeia

Documentation Changes Required

yes, screenshots.

Note

Designer's Help would be highly appreciated

@chmst chmst requested a review from drmenzelit November 8, 2020 22:24
@brianteeman
Copy link
Contributor

The image is fine but you need to resize and compress it to 640x480
AND create a template_thumbnail.png of 200x150

@richard67
Copy link
Member

@chmst If you will change colours in PR #227 e.g. due to review comments, you will have to make new thumbnail images in this PR here, because this PR here shows the colouring resulting from PR #227 .

So I suggest to wait with implementing Brian's comment above until PR #227 is finally merged.

@chmst chmst marked this pull request as draft November 11, 2020 09:50
@chmst chmst marked this pull request as ready for review November 15, 2020 16:27
@chmst
Copy link
Collaborator Author

chmst commented Nov 15, 2020

Template thumbnail and template preview added. Help of a designer for better presentation would be highly appreciated.

@brianteeman
Copy link
Contributor

Looks good to me

@richard67
Copy link
Member

@brianteeman Is it ok that the new images are 600x400 and 200x142 instead of 640x480 and 200x150? And is it ok that the preview shows a different image than the thumbnail? I'm not sure with that, so I thought maybe I should ask you.

@richard67
Copy link
Member

I see Protostar also has different sizes than 640x480 and 200x150 and different images for thumbnail and preview, so that should be ok here, too.

@richard67
Copy link
Member

I have tested this PR ✅ with success.

Well done, looks really good.

@richard67 richard67 merged commit c7156d5 into development Nov 15, 2020
@richard67 richard67 deleted the template-thumbnail branch November 15, 2020 22:05
@richard67
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants