Install Joomla for Stable Releases#35
Merged
laoneo merged 1 commit intojoomla-projects:mainfrom Aug 30, 2024
Merged
Conversation
Collaborator
|
Thanks! |
muhme
added a commit
to muhme/joomla-cypress
that referenced
this pull request
Sep 30, 2024
laoneo
pushed a commit
that referenced
this pull request
Oct 20, 2024
* Use db_port This is one puzzle piece for joomla/joomla-cms#43902 * Wrap IPv6 in brackets [ ] if port is specified. If a port number is provided, wrap IPv6 addresses with square brackets [ ]. * No square brackets for IPv6 address for PostgreSQL * installJoomla for stable releases (#35) * Update README.md (#32) * Update README.md Correcting image file name * Use absolute URL to see image in NPM README too * Square brackets on pgsql IPv6 addresses with port
muhme
added a commit
to muhme/joomla-cypress
that referenced
this pull request
Dec 3, 2024
Following joomla-projects#35, `installJoomlaMultilingualSite()` no longer works as expected because `installJoomla()` completes the installation, preventing additional installation steps from continuing. This PR resolves the issue by extracting the installation steps, allowing both `installJoomla()` and `installJoomlaMultilingualSite()` to continue with their respective actions after the primary installation.
laoneo
pushed a commit
that referenced
this pull request
Jan 10, 2025
Following #35, `installJoomlaMultilingualSite()` no longer works as expected because `installJoomla()` completes the installation, preventing additional installation steps from continuing. This PR resolves the issue by extracting the installation steps, allowing both `installJoomla()` and `installJoomlaMultilingualSite()` to continue with their respective actions after the primary installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user command
installJoomla()fails for 'Stable' Joomla releases:Reason is that the Joomla Web Installer handles different for stable releases.
For stable releases (with
DEV_STATUS = 'Stable'in filelibraries/src/Version.php)the 'Congratulations!'-screen opens on every URL until either 'Open Site' or 'Open Administrator' is clicked once.
Joomla System Tests executes an administrator backend login after
installJoomla,but as always the 'Congratulations!'-screen opens, this fails.
This PR solves the problem by checking whether such a
button.complete-installationexists, and if it does, it clicks on it.It was tested that this PR dosn't harm
installJoomlain current Joomla 4.4-dev, 5.1-dev 5.2-dev, 5.3-dev and 6.0-dev System Tests.This PR is already implemented as hack in the Joomla Branches Tester and can be seen in action there: