Fixing installJoomlaMultilingualSite()#37
Merged
laoneo merged 1 commit intojoomla-projects:mainfrom Jan 10, 2025
Merged
Conversation
Following joomla-projects#35, `installJoomlaMultilingualSite()` no longer works as expected because `installJoomla()` completes the installation, preventing additional installation steps from continuing. This PR resolves the issue by extracting the installation steps, allowing both `installJoomla()` and `installJoomlaMultilingualSite()` to continue with their respective actions after the primary installation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔔 19 Dec 2024 PM Adopted for inserted
testsdirectory level, deletedcypressfolder and moved tests intoe2esub-folder.Following #35,
installJoomlaMultilingualSite()no longer works as expected becauseinstallJoomla()completes the installation, preventing additional installation steps from continuing (ErrorExpected to find element: '#installAddFeatures', but never found it). This PR resolves the issue by extracting the installation steps, allowing bothinstallJoomla()andinstallJoomlaMultilingualSite()to continue with their respective actions after the primary installation.Exhaustive tested together with #39
You can use JBT >= 2.1.16 for testing and watch with NoVNC in parallel: