Conversation
Correcting image file name
Contributor
|
I dodn't really like the absolute path, can we not use the solution like he did here? |
Contributor
Author
|
The goal is to display the image alongside the README on npmjs.org. Since the npm registry doesn't directly host repository assets, we need to use an absolute URL. I'm not familiar with all the capabilities of the NPM registry—can we include the image directly with the package and README.md? |
Contributor
|
Thanks! |
muhme
added a commit
to muhme/joomla-cypress
that referenced
this pull request
Sep 30, 2024
* Update README.md Correcting image file name * Use absolute URL to see image in NPM README too
laoneo
pushed a commit
that referenced
this pull request
Oct 20, 2024
* Use db_port This is one puzzle piece for joomla/joomla-cms#43902 * Wrap IPv6 in brackets [ ] if port is specified. If a port number is provided, wrap IPv6 addresses with square brackets [ ]. * No square brackets for IPv6 address for PostgreSQL * installJoomla for stable releases (#35) * Update README.md (#32) * Update README.md Correcting image file name * Use absolute URL to see image in NPM README too * Square brackets on pgsql IPv6 addresses with port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correcting image file name