Conversation
Switching from Travis to Drone
Correcting test-class name
strpos with exactly !== false check
Style - Rename class Fix - Harden use of strpos()
s/archor/anchor
This allows the tests to run on PHP 8.0+. * Compatibility - Provide separate testsuite for PHP 7.1+ * Build - Update Drone configuration * Tests - Fix reconstruction test * Build - Disable PHP 5.4 and PHP 5.5. test environments Should be safe enough, if it works on PHP 5.3 and PHP 5.6.
…eam for Joomla #36774 (#30)
# Conflicts: # .drone.jsonnet # .drone.yml # .gitignore # README.md # Tests/php53/UriHelperTest.php # Tests/php53/UriImmutableTest.php # Tests/php53/UriTest.php # composer.json # phpunit.xml.dist # src/UriHelper.php # src/UriInterface.php
The merge of from 1.x-dev introduced doubled tests to solve version problems, which are no longer needed.
Contributor
|
Removing the array typehint from the |
Contributor
|
@nibra do you revert that change, otherwise we need to patch the CMS? |
Contributor
Author
|
Will do |
Contributor
|
Here we go #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Summary of Changes
Testing Instructions
Documentation Changes Required