Skip to content

Rename and typesafe strpos#25

Merged
nibra merged 2 commits intojoomla-framework:masterfrom
JProof:master
Jan 8, 2021
Merged

Rename and typesafe strpos#25
nibra merged 2 commits intojoomla-framework:masterfrom
JProof:master

Conversation

@JProof
Copy link
Contributor

@JProof JProof commented Jan 8, 2021

Pull Request for Issue #

Summary of Changes

  • Rename the UriImmuteableTest to UriImmutableTest (tea -> ta)
  • if (isset($parts['query']) && strpos($parts['query'], '&') !== false) ..strpos everytime with explizit test

Testing Instructions

nothing

Documentation Changes Required

nothing

JProof added 2 commits January 8, 2021 21:00
Correcting test-class name
strpos with exactly !== false check
@nibra nibra merged commit 7e2a8c9 into joomla-framework:master Jan 8, 2021
@nibra
Copy link
Contributor

nibra commented Jan 8, 2021

Thank you, @JProof!

@JProof
Copy link
Contributor Author

JProof commented Jan 8, 2021

Hi Niels, gerne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants