[PHP 8.1] Fix UriHelper Automatic conversion of false to array, upstream for Joomla #36774#30
Merged
nibra merged 2 commits intojoomla-framework:1.x-devfrom Jan 24, 2022
Merged
Conversation
…eam for Joomla #36774
Contributor
|
@nibra once aproved and merged please also do a release so we can pull in the change into 3.10 with an composer update. Please ping me once done :) |
Contributor
|
@beat Can you please pull in the latest changes from 1.x-dev? The tests have been fixed. |
Contributor
Author
Contributor
nibra
added a commit
that referenced
this pull request
Jan 25, 2022
* PHP8.1; Fix UriHelper Automatic conversion of false to array, upstream for Joomla #36774 (#30) Co-authored-by: Michael Babker <michael.babker@gmail.com> Co-authored-by: Hannes Papenberg <info@joomlager.de> Co-authored-by: Robert Deutz <rdeutz@googlemail.com> Co-authored-by: JProof <info@jproof.de> Co-authored-by: Phil Taylor <phil@phil-taylor.com> Co-authored-by: beat <beat@joomlapolis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue joomla-cms:#36774
See original discussion in:
joomla/joomla-cms#36774
Fixes
Deprecated: Automatic conversion of false to array is deprecated in libraries/vendor/joomla/uri/src/UriHelper.php on line 50Pull Request for Issue # none, directly fix proposal.
Summary of Changes
Another PHP 8.1 warning fix.
Testing Instructions
Just review code would be enough as it's obvious PHP 8.1 issue and fix.
Open admin aera in PHP 8.1, find this warning.
Actual result BEFORE applying this Pull Request
Deprecated: Automatic conversion of false to array is deprecated in libraries/vendor/joomla/uri/src/UriHelper.php on line 50Expected result AFTER applying this Pull Request
Not that warning anymore.
Documentation Changes Required
none.