fix(gateway): fall back to self.config for home-channel prompt - #58
Merged
Merged
Conversation
Backport of NousResearch/hermes-agent#59348 (upstream issue #10581). The 'No home channel is set' prompt only checked os.getenv(), but /sethome persists to .env + self.config (os.environ only sees .env after restart). Within a running process the prompt refired on every new session. Add self.config fallback so it respects what /sethome actually wrote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of upstream NousResearch/hermes-agent#59348 (issue #10581).
Problem
The "📬 No home channel is set..." prompt refires on every new session even after
/sethomeis run (until a gateway restart).Root cause
The prompt check in
hermes-agent/gateway/run.pyonly readsos.getenv(env_key), but/sethomewrites to.env+self.config—os.environonly picks up the.envvalue on restart, so the in-memoryself.config(updated immediately by/sethome) is ignored.Fix
Fall back to
self.config.platforms[platform].home_channelbefore deciding to show the prompt. Stops the repeat prompt without requiring a restart.