Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eglot creates too many language server processes? #270

Closed
pclalv opened this issue May 30, 2019 · 4 comments
Closed

Eglot creates too many language server processes? #270

pclalv opened this issue May 30, 2019 · 4 comments

Comments

@pclalv
Copy link

pclalv commented May 30, 2019

in short, i was wondering whether or not there's some way to configure eglot to start a single language server per project, and to then have all buffers for that language within that project communicate with that server.

for context, my experience with eglot is that it starts a process per buffer - in the case of a ruby project, it'll start a solargraph process for each ruby file that i have open. i tend to leave a bunch of buffers open, so the processes really pile up. it also seems like killing a buffer doens't kill that buffer's solargraph process. this has been taxing my computer recently, and it's gotten to the point where i'm actively looking for an easier way of doing thing.

@joaotavora
Copy link
Owner

start a single language server per project,

I can assure you that this is what Eglot does, from the very beginning. Maybe you don't have a project relating all those ruby buffers. If they are all int he same .git directory there should be some project relating them.

@joaotavora
Copy link
Owner

it also seems like killing a buffer doens't kill that buffer's solargraph process.

This is true: a project with no open buffers will not automatically kill the server (though you need at least a one-buffer-long project to start a server). This part could be changed, i.e. one could automatically kill a server if the project is emptied of buffers, subject to a customization.

@pclalv
Copy link
Author

pclalv commented May 30, 2019

okay, i understand now. i'm a projectile user; i applied this elisp and now i've got one server for all the files in my project.

i encountered that same issue before creating this one but i didn't understand what it was about. i see too that there's a point in the readme's Historical differences to lsp-mode.el section that speaks to this issue.

feel free to close this issue. thanks for your time.

ilohmar pushed a commit to ilohmar/eglot that referenced this issue Sep 24, 2019
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default nil).
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Sep 24, 2019
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default nil).
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Oct 2, 2019
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default t).
(eglot--managed-mode): Signal didClose before possibly triggering
autoshutdown.
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Oct 2, 2019
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default t).
(eglot--managed-mode): Signal didClose before possibly triggering
autoshutdown.
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Oct 2, 2019
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default t).
(eglot--managed-mode): Signal didClose before possibly triggering
autoshutdown.
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Oct 2, 2019
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default t).
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
joaotavora added a commit to ilohmar/eglot that referenced this issue Oct 5, 2019
…otavora#309)

This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
joaotavora added a commit to ilohmar/eglot that referenced this issue Oct 5, 2019
…otavora#309)

This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
joaotavora added a commit that referenced this issue Oct 5, 2019
This should close issue #217, also cf. #270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
@skangas skangas changed the title Eglot creates too many language sever processes? Eglot creates too many language server processes? Jan 9, 2022
@skangas
Copy link
Collaborator

skangas commented Jan 9, 2022

It seems like everything is done here, so I'm closing this issue. If this conclusion is incorrect, please write below and we can re-open. Thanks in advance.

@skangas skangas closed this as completed Jan 9, 2022
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 18, 2022
This should close issue joaotavora/eglot#217, also cf. joaotavora/eglot#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
This should close issue joaotavora/eglot#217, also cf. joaotavora/eglot#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
This should close issue #217, also cf. #270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>

(#309: joaotavora/eglot#309
#217: joaotavora/eglot#217
#270: joaotavora/eglot#270
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this issue Oct 12, 2022
This should close issue joaotavora/eglot#217, also cf. joaotavora/eglot#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
GitHub-reference: joaotavora/eglot#309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants