Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eglot still runs after there's no opened buffer for a project #217

Closed
rodrigues opened this issue Jan 30, 2019 · 3 comments
Closed

Eglot still runs after there's no opened buffer for a project #217

rodrigues opened this issue Jan 30, 2019 · 3 comments
Labels
enhancement

Comments

@rodrigues
Copy link

I know we have eglot-shutdown, but it would be really nice if eglot auto shuts down after there are no open buffers anymore for a project.

Maybe that's already possible and I'm not aware?

Thanks!
@joaotavora
Copy link
Owner

No, indeed it isn't. I don't know if this is a bug or a feature though. I'm going to mark this bug a feature request.

ilohmar pushed a commit to ilohmar/eglot that referenced this issue Sep 24, 2019
@ingolohmar
Implement autoshutdown when killing last buffer (joaotavora#305)
b2a174e 
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default nil).
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
@ilohmar ilohmar mentioned this issue Sep 24, 2019
Closed
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Sep 24, 2019
@ingolohmar
Option to autoshutdown after killing last buffer (joaotavora#305)
443b52e 
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default nil).
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Oct 2, 2019
@ingolohmar
Option to autoshutdown after killing last buffer (joaotavora#305)
9ebf68e 
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default t).
(eglot--managed-mode): Signal didClose before possibly triggering
autoshutdown.
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Oct 2, 2019
@ingolohmar
Option to autoshutdown after killing last buffer (joaotavora#308)
8c9c3ce 
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default t).
(eglot--managed-mode): Signal didClose before possibly triggering
autoshutdown.
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Oct 2, 2019
@ingolohmar
Option to autoshutdown after killing last buffer (joaotavora#309)
842a01f 
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default t).
(eglot--managed-mode): Signal didClose before possibly triggering
autoshutdown.
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
ilohmar pushed a commit to ilohmar/eglot that referenced this issue Oct 2, 2019
Option to autoshutdown after killing last buffer (joaotavora#309)
7efcf6b 
This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el: New defcustom `eglot-autoshutdown' (default t).
(eglot--managed-mode-onoff): Shutdown if so configured and no managed
buffers left.
joaotavora added a commit to ilohmar/eglot that referenced this issue Oct 5, 2019
@joaotavora
Optionally shutdown after killing last buffer of managed project (joa…
01fbd14 
…otavora#309)

This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
joaotavora added a commit to ilohmar/eglot that referenced this issue Oct 5, 2019
@ilohmar @joaotavora
Optionally shutdown after killing last buffer of managed project (joa…
7f49bae 
…otavora#309)

This should close issue joaotavora#217, also cf. joaotavora#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
joaotavora added a commit that referenced this issue Oct 5, 2019
@ilohmar @joaotavora
Optionally shutdown after killing last buffer of managed project (#309)
059ea59 
This should close issue #217, also cf. #270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
@nemethf
Copy link
Collaborator

nemethf commented Jan 14, 2020

059ea59 implemented auto-shutdown, so I'm closing this issue. Reopen if that's not what you want.

@nemethf nemethf closed this as completed Jan 14, 2020
@rodrigues
Copy link
Author

just tested and it works like a charm 👍

thanks for the amazing work!

bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 18, 2022
@ilohmar @joaotavora
Optionally shutdown after killing last buffer of managed project (#309)
ea6a41a 
This should close issue joaotavora/eglot#217, also cf. joaotavora/eglot#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
@ilohmar @joaotavora
Optionally shutdown after killing last buffer of managed project (#309)
8905ea8 
This should close issue joaotavora/eglot#217, also cf. joaotavora/eglot#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
bhankas pushed a commit to bhankas/emacs that referenced this issue Sep 19, 2022
@ilohmar @joaotavora
Optionally shutdown after killing last buffer of managed project (#309)
17194a5 
This should close issue #217, also cf. #270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>

(#309: joaotavora/eglot#309
#217: joaotavora/eglot#217
#270: joaotavora/eglot#270
jollaitbot pushed a commit to sailfishos-mirror/emacs that referenced this issue Oct 12, 2022
@ilohmar @joaotavora
Optionally shutdown after killing last buffer of managed project ()
ad1cc3b 
This should close issue joaotavora/eglot#217, also cf. joaotavora/eglot#270.

* eglot.el (eglot-autoshutdown): New defcustom.
(eglot--managed-mode-onoff): Shutdown if so configured and
no managed buffers left.

Co-authored-by: João Távora <[email protected]>
GitHub-reference: joaotavora/eglot#309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rodrigues @joaotavora @nemethf