Jetty 12.0.x Documentation: Logging section in operations manual #9187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 16, 2023 15:39
…for more jetty-logging.properties configuration options
…oject into jetty-12.0.x-documentation-operations-logging * 'jetty-12.0.x' of https://github.com/gregpoulos/jetty.project: Documentation: for consistency, convert "JETTY_HOME" attribute to "jetty-home" (jetty#9152) suppress test stacks Jetty 12 temp directory cleanup (jetty#9153) Only use GraalIssue5720PathResourceFactory when truly needed Refactor Graal native-image resource: handling Move GraalVM Native-Image code to NativeImagePathResource/-Factory PathResource: Fix "isAlias" issue with resource: URIs PathResource: Work-around false positive CodeQL warning PathResourceFactory: Ignore certain RuntimeExceptions upon init PathResource: Selectively enable resource: for GraalVM Native Image URIUtil: Removed unused code URIUtil: Suppress CodeQL false positive error about path injection util: Add support for GraalVM Native-Image resource:-URIs and Paths
gregpoulos
commented
Jan 17, 2023
| include::jetty[args="--add-module=http",highlight="(logging-jetty *transitively enabled|copy.*\.properties)"] | ||
| ---- | ||
|
|
||
| You can specify the following configuration options in `jetty-logging.properties`: |
There was a problem hiding this comment.
I've described a few additional configuration options in this document. All of these were drawn from the default jetty-logging.properties generated by the logging-jetty module (https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-home/src/main/resources/modules/logging/jetty/resources/jetty-logging.properties).
Do you happen to know if this is now a comprehensive list of the available options? If not, are the other configuration options documented anywhere?
gregpoulos
commented
Jan 17, 2023
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
gregpoulos
commented
Jan 17, 2023
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
gregpoulos
commented
Jan 17, 2023
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Show resolved
Hide resolved
sbordet
requested changes
Jan 18, 2023
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Show resolved
Hide resolved
documentation/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging.adoc
Outdated
Show resolved
Hide resolved
…x-documentation-operations-logging * upstream/jetty-12.0.x: (83 commits) Fix connection pool's forcible stop (jetty#9280) jetty#9240 add null checks to methods that can be used on a stopped pool retry failing tests one more time (jetty#9274) suppress stack Jetty 12.0.x reenable jetty ee9 tests (jetty#9224) Jetty 12.0.x silence tests' stacktraces (jetty#9225) More narrowly focused DEBUG logging for JavadocTransparentProxy flaky test Revert "More DEBUG on CI build/test" More DEBUG on CI build/test Adding debug to failing test to see what is causing it to fail. Removing unused / old deps Remove duplicate dependency declarations. Jetty 12 - New HTTP Cookie interface (jetty#9205) Converted PathMappings to be an AbstractMap (jetty#9213) Removing jetty-unixsocket-* references (doesn't exist in Jetty 12) Bump versions.maven.plugin.version to 2.14.2 Bump apache.directory.api.version to 2.1.2 Bump hazelcast.version to 4.2.6 Bump slf4j.version to 2.0.6 Bump osgi-service-component-version to 1.5.1 ...
|
@gregpoulos if you addressed my comments, please remember to re-elect me as reviewer. |
…x-documentation-operations-logging * upstream/jetty-12.0.x: (42 commits) fixed style cleanup TODOs for decoration Issue jetty#9300 - Rename RetainableByteBufferPool to ByteBufferPool Removed TODOs that will not be done. Rename Handler Nested & Collection (jetty#9305) fix surefire jpms configuration fix merge fix merge Bump maven.surefire.plugin.version from 3.0.0-M5 to 3.0.0-M8 (jetty#9255) Rename RetainableByteBufferPool to ByteBufferPool Fixed merge Fix jetty#9285 use possibly wrapper response for redirection (jetty#9286) Issue jetty#9293 - Jetty 12 - Relax JPMS dependencies (quic) (jetty#9307) Issue jetty#9293 - Jetty 12 - Relax JPMS dependencies (fcgi) (jetty#9306) Jetty 10 - Configurable Unsafe Host Header (jetty#9283) Issue jetty#9293 - Jetty 12 - Relax JPMS dependencies. (jetty#9296) Issue jetty#9293 - Jetty 12 - Relax JPMS dependencies. (jetty#9299) fix dependency add used dependency this dependency is used in test scope ...
I'll be looking at this today. Sorry for the delay! |
…-guide/server/server-logging-server.adoc Co-authored-by: Simone Bordet <[email protected]>
…x-documentation-operations-logging * upstream/jetty-12.0.x: Jetty 12: Cleanup `StatisticsHandler` (jetty#9291) Fixes jetty#9288 - Jetty 12 - Use oej.http.HttpCookie in jetty-client. (jetty#9289) Redo Handler renaming (jetty#9318)
…x-documentation-operations-logging * upstream/jetty-12.0.x: (35 commits) Fixes jetty#9326 - Rename DecryptedEndPoint to SslEndPoint. Jetty 10 Upgrade to Hazelcast 5 and totally disable auto join multicast etc.. (fix build on CI) (jetty#9331) jetty#9328 - changes from review jetty#9287 - catch error in ee9 maxRequestSize MultiPart test Jetty 12.0.x 9301 fix ee10 jstl jpms (jetty#9321) Issue jetty#9301 Fix dependencies for ee10-glassfish-jstl module (jetty#9303) Jetty 12 Hazelcast 5.x and disable auto detection/multicast" (jetty#9332) jetty#9287 - fix further test failures Fixed imports. Issue jetty#7650 - Fix race condition when stopping QueuedThreadPool (jetty#9325) jetty#9287 - remove unpaired release of Content.Chunk Issue jetty#8991 - rename websocket isDemanding() method to isAutoDemanding() Issue jetty#9287 - fix failing tests changes f rom review add todo to revert to normal pool after fix for jetty#9311 Issue jetty#9309 - Introducing test for requestlog format with spaces use non-pooling RetainableByteBufferPool to work around performance bug consumeAvailable should use number of reads instead of bytes fix for retainable merge changes from review ...
sbordet
requested changes
Feb 10, 2023
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Outdated
Show resolved
Hide resolved
...ion/jetty-documentation/src/main/asciidoc/operations-guide/server/server-logging-server.adoc
Show resolved
Hide resolved
sbordet
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on documentation around logging, as well as verifying that the various logging different logging frameworks work as stated in the documentation, and don't throw exceptions. So far, everything has been working according to expectations.
@sbordet, I'm hoping to get your feedback on a few points that I'll lay out in separate comments.