Converted PathMappings to be an AbstractMap #9213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was primarily done to avoid surprise of the previous behaviour of puts for a duplicate key being ignored. The use of the AbstractMap class now provides javadoc and known/expected behaviour for key methods. The only significant behaviour change is in the return type of some key methods, with the old/previous value replacing a boolean. Some stream usage has also been replaced by the more efficient iterator.
joakime
reviewed
Jan 27, 2023
jetty-core/jetty-http/src/main/java/org/eclipse/jetty/http/pathmap/PathMappings.java
Outdated
Show resolved
Hide resolved
This was primarily done to avoid surprise of the previous behaviour of puts for a duplicate key being ignored. The use of the AbstractMap class now provides javadoc and known/expected behaviour for key methods. The only significant behaviour change is in the return type of some key methods, with the old/previous value replacing a boolean. Some stream usage has also been replaced by the more efficient iterator.
joakime
approved these changes
Jan 30, 2023
gregpoulos
pushed a commit
to gregpoulos/jetty.project
that referenced
this pull request
Feb 1, 2023
…x-documentation-operations-logging * upstream/jetty-12.0.x: (83 commits) Fix connection pool's forcible stop (jetty#9280) jetty#9240 add null checks to methods that can be used on a stopped pool retry failing tests one more time (jetty#9274) suppress stack Jetty 12.0.x reenable jetty ee9 tests (jetty#9224) Jetty 12.0.x silence tests' stacktraces (jetty#9225) More narrowly focused DEBUG logging for JavadocTransparentProxy flaky test Revert "More DEBUG on CI build/test" More DEBUG on CI build/test Adding debug to failing test to see what is causing it to fail. Removing unused / old deps Remove duplicate dependency declarations. Jetty 12 - New HTTP Cookie interface (jetty#9205) Converted PathMappings to be an AbstractMap (jetty#9213) Removing jetty-unixsocket-* references (doesn't exist in Jetty 12) Bump versions.maven.plugin.version to 2.14.2 Bump apache.directory.api.version to 2.1.2 Bump hazelcast.version to 4.2.6 Bump slf4j.version to 2.0.6 Bump osgi-service-component-version to 1.5.1 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was primarily done to avoid surprise of the previous behavior of puts for a duplicate key being ignored.
The use of the AbstractMap class now provides javadoc and known/expected behavior for key methods.
The only significant behavior change is in the return type of some key methods, with the old/previous value replacing a boolean.
Some stream usage has also been replaced by the more efficient iterator.
Some methods provided by AbstractMap may not be efficient.