Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 10 Upgrade to Hazelcast 5 and totally disable auto join multicast etc.. (fix build on CI) #9331

Merged
merged 8 commits into from
Feb 9, 2023
Merged

Jetty 10 Upgrade to Hazelcast 5 and totally disable auto join multicast etc.. (fix build on CI) #9331

merged 8 commits into from
Feb 9, 2023

Conversation

olamy
Copy link
Member

@olamy olamy commented Feb 8, 2023

  • upgrade to hazelcast 5.2.1
  • disable discovery/autodetection
  • simplify disable autodetection
  • pass sys property at start

@olamy
cleanup imports
b1d7db6 
Signed-off-by: Olivier Lamy <[email protected]>
@olamy olamy changed the title Upgrade to Hazelcast 5 and totally disable auto join multicast etc.." Jetty 10 Upgrade to Hazelcast 5 and totally disable auto join multicast etc.. Feb 8, 2023
@olamy olamy changed the title Jetty 10 Upgrade to Hazelcast 5 and totally disable auto join multicast etc.. Jetty 10 Upgrade to Hazelcast 5 and totally disable auto join multicast etc.. (fix build on CI) Feb 9, 2023
lachlan-roberts
lachlan-roberts previously approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@lachlan-roberts lachlan-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can't verify it works because the failures were always on Jenkins for me, so if this passes the build I think its good.

janbartel
janbartel requested changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good ,but I think it's a little less confusing to call the new parameter autoDetectionConfigEnabled, so it resembles more the naming of getAutoDetectionConfig().setEnabled(). I'm not sure if we're now disabling something that was enabled before, or is this a new parameter?

...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java Outdated Show resolved Hide resolved
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java Outdated Show resolved Hide resolved
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java Outdated Show resolved Hide resolved
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java Outdated Show resolved Hide resolved
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java Outdated Show resolved Hide resolved
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java Outdated Show resolved Hide resolved
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java Outdated Show resolved Hide resolved
...cast/src/main/java/org/eclipse/jetty/hazelcast/session/HazelcastSessionDataStoreFactory.java Outdated Show resolved Hide resolved
jetty-hazelcast/src/test/java/org/eclipse/jetty/hazelcast/session/TestHazelcastSessions.java Outdated Show resolved Hide resolved
tests/test-sessions/test-hazelcast-sessions/pom.xml Show resolved Hide resolved
@olamy
Copy link
Member Author

olamy commented Feb 9, 2023

LGTM

Can't verify it works because the failures were always on Jenkins for me, so if this passes the build I think its good.

the fix is already in 12.0.x branch

@olamy
cleanup pom..
1756104 
Signed-off-by: Olivier Lamy <[email protected]>
@olamy olamy merged commit bd4cf3c into jetty-10.0.x Feb 9, 2023
@olamy olamy deleted the jetty-10.0.x-hazelcast-5 branch February 9, 2023 08:10
gregpoulos pushed a commit to gregpoulos/jetty.project that referenced this pull request Feb 9, 2023
Merge remote-tracking branch 'upstream/jetty-12.0.x' into jetty-12.0.…
2402b6a 
…x-documentation-operations-logging

* upstream/jetty-12.0.x: (35 commits)
  Fixes jetty#9326 - Rename DecryptedEndPoint to SslEndPoint.
  Jetty 10 Upgrade to Hazelcast 5 and totally disable auto join multicast etc.. (fix build on CI) (jetty#9331)
  jetty#9328 - changes from review
  jetty#9287 - catch error in ee9 maxRequestSize MultiPart test
  Jetty 12.0.x 9301 fix ee10 jstl jpms (jetty#9321)
  Issue jetty#9301 Fix dependencies for ee10-glassfish-jstl module (jetty#9303)
  Jetty 12 Hazelcast 5.x and disable auto detection/multicast" (jetty#9332)
  jetty#9287 - fix further test failures
  Fixed imports.
  Issue jetty#7650 - Fix race condition when stopping QueuedThreadPool (jetty#9325)
  jetty#9287 - remove unpaired release of Content.Chunk
  Issue jetty#8991 - rename websocket isDemanding() method to isAutoDemanding()
  Issue jetty#9287 - fix failing tests
  changes f rom review
  add todo to revert to normal pool after fix for jetty#9311
  Issue jetty#9309 - Introducing test for requestlog format with spaces
  use non-pooling RetainableByteBufferPool to work around performance bug
  consumeAvailable should use number of reads instead of bytes
  fix for retainable merge
  changes from review
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbartel janbartel janbartel approved these changes

@lachlan-roberts lachlan-roberts lachlan-roberts left review comments

Assignees
No one assigned
Labels
Build Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olamy @janbartel @lachlan-roberts