Issue #3648 - SimpleContainerScope should use WebSocket Behavior for SSL defaults #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SSL defaults Signed-off-by: Joakim Erdfelt <[email protected]>
This was referenced May 14, 2019
sbordet
requested changes
May 20, 2019
| { | ||
| QueuedThreadPool threadPool = new QueuedThreadPool(); | ||
| String behavior = "Container"; | ||
| if (policy != null) |
There was a problem hiding this comment.
Why this null check here? You would have already gotten a NPE at line 142 above, no?
| @@ -166,4 +133,44 @@ public void removeSessionListener(WebSocketSessionListener listener) | |||
| { | |||
| return sessionListeners; | |||
| } | |||
|
|
|||
| @Override | |||
| protected void doStart() throws Exception | |||
There was a problem hiding this comment.
I don't think it's right to move the initialization code that before was in the constructor to doStart().
For example, WebSocketClient constructor calls HttpClientProvider.get(scope) passing in a scope that is not yet started, which get passed to DefaultHttpClientProvider.newHttpClient(scope) which uses the scope before it's started.
I think we need a better review of the lifecycle of the scope to move things to a different place.
Signed-off-by: Joakim Erdfelt <[email protected]>
|
|
|
I am going to submit 3 separate PRs for this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joakim Erdfelt [email protected]