Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocketClient constructor cleanup (and deprecations) #3730

Closed
joakime opened this issue Jun 4, 2019 · 1 comment · Fixed by #4423
Closed

WebSocketClient constructor cleanup (and deprecations) #3730

joakime opened this issue Jun 4, 2019 · 1 comment · Fixed by #4423
Assignees
@joakime
Labels
Enhancement Low Priority

Comments

@joakime
Copy link
Contributor

joakime commented Jun 4, 2019

While performing a review of PR #3651 it has become apparent that the websocket scopes and configuration behaviors in Jetty 9.4.x is confusing.

Should clean this up to be less confusing and better documented.
@joakime joakime self-assigned this Jun 4, 2019
This was referenced Jun 4, 2019
Closed
Merged
joakime added a commit that referenced this issue Dec 13, 2019
@joakime
Issue #3730 - Cleaning up Scopes in WebSocketClient
7d65183 
+ Introducing HttpContainerScope to track HttpClient specific
  ByteBufferPool, SslContextFactory, and Executor.
+ New private WebSocketClient constructor that use HttpContainerScope
+ Deprecated many constructors as irrelevant now that HttpClient
  is an option to create a WebSocketClient.

Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime mentioned this issue Dec 13, 2019
Merged
@joakime
Copy link
Contributor Author

joakime commented Dec 13, 2019

Opened PR #4423

joakime added a commit that referenced this issue Dec 18, 2019
@joakime
Issue #3730 - Removing HttpContainerScope
9da1820 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Dec 18, 2019
@joakime
Issue #3730 - Making new Constructor private
e02ef3e 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Dec 18, 2019
@joakime
Issue #3730 - Collapsing now redundant private Constructor
bb79f3e 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Dec 19, 2019
@joakime
Issue #3730 - Further updates from PR Review
9498859 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Dec 19, 2019
@joakime
Issue #3730 - Updating invalid test assertion
26fde02 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Dec 19, 2019
@joakime
Issue #3730 - EventDriverFactory and SessionFactory setters
c2c2c56 
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Dec 19, 2019
@joakime
Merge pull request #4423 from eclipse/jetty-9.4.x-3730-websocket-scop…
cef67d9 
…e-cleanup

Issue #3730 - Cleaning up Scopes in WebSocketClient
@joakime joakime changed the title Cleanup WebSocket Scopes / Configuration confusion WebSocketClient constructor cleanup (and deprecations) Dec 20, 2019
This was referenced Dec 16, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Enhancement Low Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #3730 - Cleaning up Scopes in WebSocketClient jetty/jetty.project
1 participant
@joakime