Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing of CDI behaviors #3731

Closed
joakime opened this issue Jun 4, 2019 · 2 comments
Closed

Add testing of CDI behaviors #3731

joakime opened this issue Jun 4, 2019 · 2 comments
Assignees
Labels

Comments

@joakime
Copy link
Contributor

joakime commented Jun 4, 2019

We currently have in the jetty-9.4.x branch 3 different ways to use CDI.

  1. There's the built into the webapp approach where weld is included as a library in the WEB-INF/lib
  2. There's the old CDI 1 server side setup / behaviors from the jetty-cdi top level module
  3. There's the new CDI 2 server side setup / behaviors introduced from issue Update to CDI 2.0 for cdi module #1900

Now that we have a /tests/test-distribution/ module, we should make sure that the various behaviors still work, or remove them (I suspect that the server side CDI 1 behavior has no reason to exist anymore as the server side CDI 2 behaviors should be backwards compatible)

@joakime joakime added the Test label Jun 4, 2019
@joakime joakime self-assigned this Jun 4, 2019
joakime added a commit that referenced this issue Jun 5, 2019
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Jun 5, 2019
joakime added a commit that referenced this issue Jun 5, 2019
joakime added a commit that referenced this issue Jun 5, 2019
@joakime
Copy link
Contributor Author

joakime commented Jun 6, 2019

Opened PR #3737

@janbartel would you be ok with me deleting the old, CDI1, long since deprecated jetty-cdi stuff? it was experimental, and doesn't work anyway.
I would leave the cdi2 module, but expand on it slightly to include some extra [depends], and fix the XML that updates the WebAppClassLoader.

joakime added a commit that referenced this issue Jun 6, 2019
joakime added a commit that referenced this issue Jun 6, 2019
joakime added a commit that referenced this issue Jun 6, 2019
+ Moved remaining CDI2 module to top level /jetty-cdi/ (no need for
  sub-modules anymore)
joakime added a commit that referenced this issue Jun 12, 2019
Signed-off-by: Joakim Erdfelt <[email protected]>
joakime added a commit that referenced this issue Jun 12, 2019
joakime added a commit that referenced this issue Jun 12, 2019
joakime added a commit that referenced this issue Jun 12, 2019
joakime added a commit that referenced this issue Jun 12, 2019
joakime added a commit that referenced this issue Jun 12, 2019
+ Moved remaining CDI2 module to top level /jetty-cdi/ (no need for
  sub-modules anymore)
joakime added a commit that referenced this issue Jun 12, 2019
joakime added a commit that referenced this issue Jun 21, 2019
joakime added a commit that referenced this issue Jun 21, 2019
@joakime
Copy link
Contributor Author

joakime commented Jul 31, 2019

Merged PR #3737

@joakime joakime closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant