Skip to content

docs(rfc): flip RFC 0041 to green — plugins shipped, dashboard verified - #662

Merged
jensholdgaard merged 3 commits into
mainfrom
rfc0041-green
Jul 27, 2026
Merged

docs(rfc): flip RFC 0041 to green — plugins shipped, dashboard verified#662
jensholdgaard merged 3 commits into
mainfrom
rfc0041-green

Conversation

@jensholdgaard

@jensholdgaard jensholdgaard commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

Maintainer-approved flip of RFC 0041 (dashboard datasource plugins) from specified to green (2026-07-27).

Verification

mdbook build clean; repo-wide grep shows no stale specified references to RFC 0041 outside historical parentheticals. Docs-only — no code, no invariants or hazards touched.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F

Summary by CodeRabbit

  • Documentation
    • Updated the RFC status to green, documenting verified acceptance criteria and remaining compatibility limitations.
    • Clarified that the Grafana datasource and selected compatibility checks remain follow-up work.
    • Updated the roadmap to reflect shipped Perses plugins and the FinOps dashboard rendering against live data.
    • Noted that CRDs and operator support require a separate RFC.

Maintainer flip (2026-07-27). RFC0041.1-.4 and the .6 capstone are
verified per the SS9 record; RFC0041.5 stays partial by recorded
deferral (0.5.0 pinned and CI-exercised; the latest matrix leg and
wire-level sum e2e land with the next server release, the first to
carry RFC 0042 typed columns — precedent: RFC 0005's ignored sizing
criterion at green). Roadmap ladder, banner, and the deferred-scope
table row updated to match.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
@jensholdgaard
jensholdgaard requested a review from Copilot July 27, 2026 19:40
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0935d7bb-b2b3-4e5e-87aa-ca9482d0752c

📥 Commits

Reviewing files that changed from the base of the PR and between 948242f and 70459c2.

📒 Files selected for processing (1)
  • docs/roadmap.md
📝 Walkthrough

Walkthrough

RFC0041 documentation now marks the dashboard datasource plugin work as green, records verified Perses plugins and dashboard rendering, and identifies RFC0041.5 compatibility checks and Grafana integration as follow-up work.

Changes

RFC0041 status documentation

Layer / File(s) Summary
RFC status and acceptance record
docs/rfcs/0041-dashboard-datasource-plugins.md
The RFC status, verification banner, and RFC0041.5 acceptance criterion now record the green state and partial compatibility scope.
Roadmap status alignment
docs/roadmap.md
Roadmap status, progress, open-work, and MVP scope entries now describe the shipped Perses plugins, rendered dashboard, deferred RFC0041.5 checks, and Grafana follow-up.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning It covers the main summary, but it omits the required Related section and the checklist from the template. Add the Related section with the RFC link and fill out the checklist items required by the repository template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the RFC 0041 green flip and the shipped and verified plugin/dashboard work.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rfc0041-green

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the documentation to reflect that RFC 0041 (dashboard datasource plugins) has been flipped from specified to green, and aligns the project roadmap language with the recorded verification and deferral.

Changes:

  • Update docs/rfcs/0041-dashboard-datasource-plugins.md banner and acceptance-criteria annotation to reflect green status and the recorded partial deferral for RFC0041.5.
  • Update docs/roadmap.md to mark RFC 0041 as green and adjust roadmap “what remains” and deferred-capabilities entries accordingly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/roadmap.md Updates roadmap narrative and tables to reflect RFC 0041 now being green, including the recorded deferral note.
docs/rfcs/0041-dashboard-datasource-plugins.md Flips the RFC’s banner to green and annotates RFC0041.5 as a partial/recorded deferral at the green gate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/rfcs/0041-dashboard-datasource-plugins.md
Comment thread docs/rfcs/0041-dashboard-datasource-plugins.md Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docs/rfcs/0041-dashboard-datasource-plugins.md (1)

287-295: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Scope RFC0041.5’s acceptance criterion to the recorded deferral.

The banner says the 0.5.0 minimum-image leg is exercised while the latest matrix leg is deferred, but this criterion still requires the e2e suite to run against both. Split the requirement so the current green status is accurate and the latest leg is explicitly future work.

Proposed adjustment
-  - **Then** the e2e suite executes against exactly that image tag
-    alongside `latest`
+  - **Then** the e2e suite executes against exactly that minimum image tag
+    (`0.5.0`)
+  - **And** the `latest` matrix leg is recorded as deferred until the next
+    server release carrying RFC 0042 typed columns
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/rfcs/0041-dashboard-datasource-plugins.md` around lines 287 - 295,
Update the RFC0041.5 acceptance criterion to match the recorded deferral:
require CI to run the e2e suite against the declared minimum `ourios-server`
image tag, while marking the `latest` matrix leg as deferred future work.
Preserve the requirement that contract breaks fail the plugin gate.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/roadmap.md`:
- Line 416: Update the introductory Perses roadmap summary above the table from
“still fully deferred” to “partially landed,” preserving the surrounding wording
and leaving the detailed “Perses dashboard integration” row unchanged.

---

Outside diff comments:
In `@docs/rfcs/0041-dashboard-datasource-plugins.md`:
- Around line 287-295: Update the RFC0041.5 acceptance criterion to match the
recorded deferral: require CI to run the e2e suite against the declared minimum
`ourios-server` image tag, while marking the `latest` matrix leg as deferred
future work. Preserve the requirement that contract breaks fail the plugin gate.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e7ef631-883a-404f-b3ce-0f1f2c3f5045

📥 Commits

Reviewing files that changed from the base of the PR and between b223917 and 948242f.

📒 Files selected for processing (2)
  • docs/rfcs/0041-dashboard-datasource-plugins.md
  • docs/roadmap.md

Comment thread docs/roadmap.md
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
@jensholdgaard
jensholdgaard requested a review from Copilot July 27, 2026 21:10
@jensholdgaard
jensholdgaard merged commit 4ea4d76 into main Jul 27, 2026
28 checks passed
@jensholdgaard
jensholdgaard deleted the rfc0041-green branch July 27, 2026 21:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment on lines +287 to 291
- **RFC0041.5 — compatibility declaration, CI-exercised** *(partial at
`green` — recorded deferral, see banner + §9.1)*
- **Given** plugin release metadata declaring its minimum
`ourios-server` version
- **When** the plugin repository's CI runs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants