Skip to content

docs(rfc): flip RFCs 0043 and 0044 to accepted — maintainer sign-off - #677

Merged
jensholdgaard merged 1 commit into
mainfrom
rfc-accepted-0043-0044
Jul 29, 2026
Merged

docs(rfc): flip RFCs 0043 and 0044 to accepted — maintainer sign-off#677
jensholdgaard merged 1 commit into
mainfrom
rfc-accepted-0043-0044

Conversation

@jensholdgaard

Copy link
Copy Markdown
Owner

Summary

Batch maintainer flip (2026-07-29): RFC 0043 (event_name from the legacy attribute) and RFC 0044 (template-aware body equality) both go greenaccepted (terminal). Neither touches a benchmarks.md §7 pillar, so validated is vacuous — the RFC 0008 precedent — and green was each RFC's last verification stage. RFC 0044's deliberately-open §7 fork (substring/ordering/regex on body) survives acceptance as a tracked follow-up. Frontmatter and banners flipped together (the #662 lesson).

Maintainer authorization: this session, 2026-07-29 ("lets flip those also").

mdbook build clean; docs-only.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F

Batch maintainer flip (2026-07-29). Neither touches a benchmarks.md §7
pillar, so validated is vacuous (RFC 0008 precedent) and green was each
RFC's last verification stage. RFC 0044's open §7 fork (substring/
ordering/regex on body) survives acceptance as a tracked follow-up.
Frontmatter and banners flipped together.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
@jensholdgaard
jensholdgaard requested a review from Copilot July 29, 2026 11:07
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0cfedfa9-ea20-4f63-ac69-d8912d2a4289

📥 Commits

Reviewing files that changed from the base of the PR and between f51a6e1 and 5d1a815.

📒 Files selected for processing (2)
  • docs/rfcs/0043-event-name-attribute-ingest.md
  • docs/rfcs/0044-template-aware-body-equality.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This docs-only PR updates RFC metadata and banners to reflect maintainer sign-off, flipping RFC 0043 and RFC 0044 from green to terminal accepted status, consistent with the repo’s existing “accepted + prior green note” RFC pattern.

Changes:

  • Update RFC 0043 frontmatter status to accepted and add an “accepted” status banner note.
  • Update RFC 0044 frontmatter status to accepted and add an “accepted” status banner note (preserving the tracked §7 follow-up fork).
  • Retain the existing green status notes as historical verification context, matching other accepted RFCs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
docs/rfcs/0044-template-aware-body-equality.md Flip RFC 0044 to accepted and add an accepted status banner while retaining the green verification note.
docs/rfcs/0043-event-name-attribute-ingest.md Flip RFC 0043 to accepted and add an accepted status banner while retaining the green verification note.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jensholdgaard
jensholdgaard merged commit 36e21cd into main Jul 29, 2026
28 checks passed
@jensholdgaard
jensholdgaard deleted the rfc-accepted-0043-0044 branch July 29, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants