docs(rfc): commit the RFC0041.6 FinOps dashboard artifact - #661
Conversation
The Perses dashboard definition the RFC0041.6 capstone clause requires, under examples/perses/: spend by model over the RFC 0042 typed Float64 column, output-token throughput (Int64), tool-decision mix, and the event-log panel — plus the proxy datasource example (tenant header injected server-side, /v1/query + /mcp allowed) and an import README. Verified by importing the committed file unmodified into Perses 0.53.1 with the built ourios-perses-plugin archive against the live dogfood capture: every panel renders, idle hours draw as gaps (never zeros). RFC 0041 gains the §9 verification record for .1-.6. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds Perses datasource and FinOps dashboard examples, usage instructions, rendering expectations, and RFC 0041 verification details covering plugin delivery and dashboard import testing. ChangesPerses dashboard examples
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Commits the RFC0041.6 capstone artifact by adding a Perses FinOps dashboard definition plus supporting datasource/README examples, and records the verification run in RFC 0041.
Changes:
- Add
agent-finops.jsonPerses dashboard (spend, tokens, tool decisions, recent events) using the public Ourios logs DSL. - Add a Perses
Datasourceexample (HTTPProxyallowed endpoints + tenant header) and import instructions. - Extend RFC 0041 with a §9 verification record documenting the rendered dashboard against the dogfood capture.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/perses/README.md | Documents prerequisites and percli apply steps for importing the datasource + dashboard. |
| examples/perses/datasource.example.json | Adds a Perses datasource example configured to proxy POST /v1/query and POST /mcp with a tenant header. |
| examples/perses/agent-finops.json | Adds the RFC0041.6 Perses dashboard definition with four panels backed by Ourios DSL queries. |
| docs/rfcs/0041-dashboard-datasource-plugins.md | Adds §9 verification record describing plugin/dash rendering and query-surface behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/perses/agent-finops.json`:
- Around line 127-139: Update the LogQuery plugin configuration in the “Recent
agent events” panel to scope results to the Claude Code telemetry stream by
adding the com.anthropic.claude_code.events predicate alongside the existing
severity filter. Preserve the limit and other query behavior.
In `@examples/perses/README.md`:
- Around line 20-24: Update the command examples in the README snippet so both
percli apply commands reference the files under examples/perses/ when run from
the repository root, while preserving the existing filenames and command
structure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5e9e6969-1926-446b-b964-ace33802a6b9
📒 Files selected for processing (4)
docs/rfcs/0041-dashboard-datasource-plugins.mdexamples/perses/README.mdexamples/perses/agent-finops.jsonexamples/perses/datasource.example.json
… paths The log panel now filters to the claude_code events scope like the metric panels (predicates combine with 'and' before the first pipe — the suggested '| severity >=' form is not a pipe stage and the querier rejects it, caught by re-rendering). README import commands run from the repository root; the §9.2 body-shape phrasing no longer reads as a JSON literal. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F Signed-off-by: Jens Holdgaard Pedersen <Jens@holdgaard.org>
Summary
The RFC0041.6 capstone artifact: the committed Perses FinOps dashboard, verified rendering against the live dogfood capture with no manual edits to the definition.
examples/perses/agent-finops.json— four panels: spend by model (sum(attr.cost_usd) by attr.model, bucket(1h), the RFC 0042 typed Float64 column), output-token throughput (Int64), tool-decision mix, and a LogsTable of recent agent events (RFC0002.21 floor admits unspecified-severity GenAI events).examples/perses/datasource.example.json— the proxy datasource shape: tenant header injected server-side,POST /v1/query+POST /mcp(schema suggestions, RFC 0032) allowed.examples/perses/README.md— prerequisites andpercli applyimport steps.Verification
Imported the committed file unmodified (API upsert, HTTP 200) into Perses 0.53.1 with the built
ourios-perses-pluginarchive, against the liveagent-dogfoodcapture served by the dogfood querier. Every panel rendered from the capture: two model series (claude-fable-5,claude-haiku-4-5, ~$391 across the day's buckets), ~40K/h token peaks, decision counts, and the event log. Idle hours render as gaps, never zeros — the RFC 0042 null-propagation contract on screen.Checks run:
mdbook build(clean). No Rust code touched — fmt/clippy/test not applicable to this change.Invariants / hazards
Docs + committed example only; no data-path code. Hazard #6 (DSL vs DataFusion surface): the dashboard consumes only the public DSL over
POST /v1/query— the time range arrives as a DSLrange(...)stage per the plugin'swithRange, nothing host-specific leaks into the query surface.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qtny6z6cA74xPZa4qRhk4F
Summary by CodeRabbit
New Features
Documentation