Skip to content

docs(rfc): advance RFC 0002 + RFC 0007 to green - #155

Merged
jensholdgaard merged 3 commits into
mainfrom
docs/rfc0002-rfc0007-green
Jun 7, 2026
Merged

docs(rfc): advance RFC 0002 + RFC 0007 to green#155
jensholdgaard merged 3 commits into
mainfrom
docs/rfc0002-rfc0007-green

Conversation

@jensholdgaard

@jensholdgaard jensholdgaard commented Jun 7, 2026

Copy link
Copy Markdown
Owner

What

Advances two RFC statuses now that the query-DSL workstream is complete:

  • RFC 0002 → green — all 11 §5 acceptance criteria (RFC0002.1–.11) have passing tests in crates/ourios-querier/tests/rfc0002_dsl.rs (15 tests, 0 ignored), landed across docs(rfc-0002): specify the query DSL — Branch B, surface β #143feat(querier): expand resolves_to via the alias map (RFC0002.9) #154: Branch-B parser + structured JSON surface → one IR; IR→DataFusion compile; YAML-embeddability + the published/snapshotted structured JSON Schema; and resolves_to alias-set expansion via the RFC 0001 §6.7 operator alias map.
  • RFC 0007 → green — RFC0007.1–.5 have live passing tests (tests/execution.rs, tests/boundary.rs, tests/forward_compat.rs, the lib.rs no-leakage unit test). The status was held at specified only by the prove-thesis gate (it deliberately didn't re-decide the DSL surface); that gate is cleared now the DSL is fully green, so the execution frontend advances.

Not advanced (deliberate)

  • RFC 0001 stays specified — the alias write path (.12–.16) is green, but the core miner criteria RFC0001.5/.6/.8/.9/.10/.11 plus the hazard/invariant scenarios are still #[ignore]'d red-gate stubs (crates/ourios-miner/tests/{rfc_internal,hazards,invariants}.rs). RFC 0001 is not green and this PR does not claim it.

Verification

  • mdbook build clean. Doc-only (front-matter status: + status notes). validated/accepted still follow per the README ladder (RFC 0007's validated is the B1/B2 thesis-gate measurement).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated specification documentation to reflect that acceptance criteria now have comprehensive test coverage and are validated as production-ready.

RFC 0002: all 11 §5 criteria (RFC0002.1-.11) pass
(crates/ourios-querier/tests/rfc0002_dsl.rs), #144-#154 — parser +
structured surface, IR->DataFusion compile, YAML + JSON schema, and
resolves_to alias expansion via the RFC 0001 §6.7 operator alias map.

RFC 0007: RFC0007.1-.5 have live passing tests; the prove-thesis gate is
cleared now the DSL is green, so the execution frontend advances
specified->green. (RFC 0001 stays specified — its miner criteria
.5/.6/.8/.9/.10/.11 + hazards/invariants are still red-gate stubs.)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jensholdgaard
jensholdgaard requested a review from Copilot June 7, 2026 22:30
@jensholdgaard

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jensholdgaard, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 52 minutes and 43 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2b0d1765-dad0-4a7a-843b-f5a461e5ca27

📥 Commits

Reviewing files that changed from the base of the PR and between bec8048 and 237a93e.

📒 Files selected for processing (2)
  • docs/rfcs/0002-query-dsl.md
  • docs/rfcs/0007-querier.md
📝 Walkthrough

Walkthrough

This PR updates the status of two RFCs from specified to green. RFC0002 (Query DSL) and RFC0007 (Querier) status fields and "Status note" sections are rewritten to document that their acceptance criteria now have passing tests. RFC0007's update explicitly references RFC0002's DSL gating milestone.

Changes

RFC Status Advancement to Green

Layer / File(s) Summary
RFC0002 Query DSL status advancement
docs/rfcs/0002-query-dsl.md
RFC0002 status changed from specified to green. "Status note" rewritten to document acceptance-criteria test coverage for Branch-B parsing, structured surface, IR compilation, YAML/JSON-schema, and alias-expansion work.
RFC0007 Querier status advancement
docs/rfcs/0007-querier.md
RFC0007 status changed from specified to green. "Status note" rewritten to document that RFC0007.1–.5 acceptance criteria have live passing tests, with execution-layer measurement (B1/B2) pinned after DSL gating cleared (RFC 0002).

Possibly Related PRs

  • jensholdgaard/ourios#149: Completes RFC0002.10/.11 acceptance criteria with schema exposure and validation work that supports the green status marked in this RFC update.
  • jensholdgaard/ourios#143: Prior RFC0002 specification and acceptance-criteria rewrite that established the basis for the test coverage now documented in this PR.
  • jensholdgaard/ourios#83: Related update to RFC0007 status and "Status note" documentation reflecting acceptance-criteria test coverage.

Poem

🐰 Two RFCs now wear their emerald crown,
Green status shining bright, no longer brown.
Tests passing, criteria met with care,
Query DSL and Querier, a matched pair! ✨

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: advancing two RFCs (0002 and 0007) to green status.
Description check ✅ Passed The description includes a comprehensive Summary section explaining what is being done and why, Related section with relevant RFC references, and addresses the Checklist items appropriately for a documentation-only change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/rfc0002-rfc0007-green

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Advances RFC documentation statuses to reflect that the query-DSL workstream and the querier execution frontend now have fully passing acceptance-criteria tests, moving both RFCs to the green gate in the project’s RFC maturity ladder.

Changes:

  • Update RFC 0002 (Query DSL) frontmatter status: to green and revise the status note to reference the now-passing RFC0002.x test coverage.
  • Update RFC 0007 (Querier) frontmatter status: to green and revise the status note to reference the now-passing RFC0007.x test coverage and gating rationale.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/rfcs/0002-query-dsl.md Marks RFC 0002 as green and updates the status note with references to the acceptance-criteria tests and related workstream milestones.
docs/rfcs/0007-querier.md Marks RFC 0007 as green and updates the status note to document which tests satisfy RFC0007.1–.5 and why the RFC can advance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/rfcs/0007-querier.md Outdated
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread docs/rfcs/0002-query-dsl.md Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/rfcs/0002-query-dsl.md`:
- Around line 20-22: The green-status evidence lists PRs as "`#144`–#154" but the
landed work includes PR `#143`; update the PR range in the status note in
docs/rfcs/0002-query-dsl.md (the green-status line referencing
`crates/ourios-querier/tests/rfc0002_dsl.rs` and the PR list) to include `#143`
(e.g., change "`#144`–#154" to "`#143`–#154") so the document matches the actual
completion chain.

In `@docs/rfcs/0007-querier.md`:
- Around line 14-27: The status paragraph claims RFC0002 §3 has landed and
RFC0007 is "green" but §8 still states parser integration is blocked on RFC0002
§3, creating a contradiction; update docs/rfcs/0007-querier.md to reconcile
these by either (A) removing or rewording the §8 blocker text so it reflects
that RFC0002 §3 (Branch B) has landed and parser integration is no longer
blocked, or (B) if parser integration truly remains blocked for other reasons,
change the status note to not claim RFC0007 is "green"/cleared; edit the "Status
note" section and the §8 "parser integration" paragraph to consistently
reference RFC0002 §3 and the current gate outcome (RFC0007, §5 acceptance tests
and B1/B2 thesis-gate) so both statements align.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: aeaba329-a5bd-463d-92d3-c96589e2b4bf

📥 Commits

Reviewing files that changed from the base of the PR and between d8a6651 and bec8048.

📒 Files selected for processing (2)
  • docs/rfcs/0002-query-dsl.md
  • docs/rfcs/0007-querier.md

Comment thread docs/rfcs/0002-query-dsl.md
Comment thread docs/rfcs/0007-querier.md
…e blocker

Review: RFC 0002 status note now credits #143 (the spec PR) alongside
#144-#154; RFC 0007 §8 + the alternatives no longer say parser integration
is blocked on the RFC 0002 §3 branch decision (resolved, Branch B) — the
contradiction with the green status note is removed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@jensholdgaard
jensholdgaard merged commit af1c3cd into main Jun 7, 2026
11 checks passed
@jensholdgaard
jensholdgaard deleted the docs/rfc0002-rfc0007-green branch June 7, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants