docs(rfc): advance RFC 0002 + RFC 0007 to green - #155
Conversation
RFC 0002: all 11 §5 criteria (RFC0002.1-.11) pass (crates/ourios-querier/tests/rfc0002_dsl.rs), #144-#154 — parser + structured surface, IR->DataFusion compile, YAML + JSON schema, and resolves_to alias expansion via the RFC 0001 §6.7 operator alias map. RFC 0007: RFC0007.1-.5 have live passing tests; the prove-thesis gate is cleared now the DSL is green, so the execution frontend advances specified->green. (RFC 0001 stays specified — its miner criteria .5/.6/.8/.9/.10/.11 + hazards/invariants are still red-gate stubs.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@coderabbitai review |
|
Warning Review limit reached
More reviews will be available in 52 minutes and 43 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates the status of two RFCs from ChangesRFC Status Advancement to Green
Possibly Related PRs
Poem
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
Advances RFC documentation statuses to reflect that the query-DSL workstream and the querier execution frontend now have fully passing acceptance-criteria tests, moving both RFCs to the green gate in the project’s RFC maturity ladder.
Changes:
- Update RFC 0002 (Query DSL) frontmatter
status:togreenand revise the status note to reference the now-passing RFC0002.x test coverage. - Update RFC 0007 (Querier) frontmatter
status:togreenand revise the status note to reference the now-passing RFC0007.x test coverage and gating rationale.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/rfcs/0002-query-dsl.md | Marks RFC 0002 as green and updates the status note with references to the acceptance-criteria tests and related workstream milestones. |
| docs/rfcs/0007-querier.md | Marks RFC 0007 as green and updates the status note to document which tests satisfy RFC0007.1–.5 and why the RFC can advance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/rfcs/0002-query-dsl.md`:
- Around line 20-22: The green-status evidence lists PRs as "`#144`–#154" but the
landed work includes PR `#143`; update the PR range in the status note in
docs/rfcs/0002-query-dsl.md (the green-status line referencing
`crates/ourios-querier/tests/rfc0002_dsl.rs` and the PR list) to include `#143`
(e.g., change "`#144`–#154" to "`#143`–#154") so the document matches the actual
completion chain.
In `@docs/rfcs/0007-querier.md`:
- Around line 14-27: The status paragraph claims RFC0002 §3 has landed and
RFC0007 is "green" but §8 still states parser integration is blocked on RFC0002
§3, creating a contradiction; update docs/rfcs/0007-querier.md to reconcile
these by either (A) removing or rewording the §8 blocker text so it reflects
that RFC0002 §3 (Branch B) has landed and parser integration is no longer
blocked, or (B) if parser integration truly remains blocked for other reasons,
change the status note to not claim RFC0007 is "green"/cleared; edit the "Status
note" section and the §8 "parser integration" paragraph to consistently
reference RFC0002 §3 and the current gate outcome (RFC0007, §5 acceptance tests
and B1/B2 thesis-gate) so both statements align.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: aeaba329-a5bd-463d-92d3-c96589e2b4bf
📒 Files selected for processing (2)
docs/rfcs/0002-query-dsl.mddocs/rfcs/0007-querier.md
…e blocker Review: RFC 0002 status note now credits #143 (the spec PR) alongside #144-#154; RFC 0007 §8 + the alternatives no longer say parser integration is blocked on the RFC 0002 §3 branch decision (resolved, Branch B) — the contradiction with the green status note is removed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What
Advances two RFC statuses now that the query-DSL workstream is complete:
green— all 11 §5 acceptance criteria (RFC0002.1–.11) have passing tests incrates/ourios-querier/tests/rfc0002_dsl.rs(15 tests, 0 ignored), landed across docs(rfc-0002): specify the query DSL — Branch B, surface β #143–feat(querier): expand resolves_to via the alias map (RFC0002.9) #154: Branch-B parser + structured JSON surface → one IR; IR→DataFusion compile; YAML-embeddability + the published/snapshotted structured JSON Schema; andresolves_toalias-set expansion via the RFC 0001 §6.7 operator alias map.green— RFC0007.1–.5 have live passing tests (tests/execution.rs,tests/boundary.rs,tests/forward_compat.rs, thelib.rsno-leakage unit test). The status was held atspecifiedonly by the prove-thesis gate (it deliberately didn't re-decide the DSL surface); that gate is cleared now the DSL is fully green, so the execution frontend advances.Not advanced (deliberate)
specified— the alias write path (.12–.16) is green, but the core miner criteria RFC0001.5/.6/.8/.9/.10/.11 plus the hazard/invariant scenarios are still#[ignore]'d red-gate stubs (crates/ourios-miner/tests/{rfc_internal,hazards,invariants}.rs). RFC 0001 is not green and this PR does not claim it.Verification
mdbook buildclean. Doc-only (front-matterstatus:+ status notes).validated/acceptedstill follow per the README ladder (RFC 0007'svalidatedis the B1/B2 thesis-gate measurement).🤖 Generated with Claude Code
Summary by CodeRabbit