feat(querier): expand resolves_to via the alias map (RFC0002.9)

[jensholdgaard]

Summary

SLICE B (final slice) of the RFC 0001 alias-index write path: wire the
in-memory alias map into the querier so resolves_to(n) expands to the
whole RFC 0001 §6.7 equivalence class of n, flipping the last RFC 0002
criterion RFC0002.9 from an ignored stub to a real cross-alias test.

Builds on SLICE A (#153 — ourios-core AliasMap + audited
assert/retract + resolves).

What changed

Alias-map threading. Querier::run_query now takes an
&ourios_core::alias::AliasMap alongside the existing
tenant/now/default-window:

pub async fn run_query(
    &self,
    query: &dsl::Query,
    tenant: &TenantId,
    now_unix_nano: u64,
    default_window_nanos: u64,
    alias_map: &ourios_core::alias::AliasMap,   // new
) -> Result<QueryResult, QueryError>

The map is an in-memory projection injected by the caller — no
on-disk loading is added here; the physical map artifact (serialization,
snapshot cadence) is the RFC 0005 storage split (sibling to #147),
flagged not built.

in_list expansion. compile::compile resolves every
resolves_to(n) in the predicate against the tenant's map once, at
compile time (collect_alias_classes), and stores the sorted class on
the Plan. Call::ResolvesTo(n) then compiles to template_id IN (class) (a DataFusion in_list over the sorted ids). A singleton class
(no alias on n) is template_id IN (n) — behaviourally identical to
the prior template_id == n, so non-aliased queries are unchanged.

Contract change (intended, maintainer-approved). RFC0002.9 moves
from base-member semantics (resolves_to(n) == template_id == n)
to true alias-set expansion. The criterion's §5 description already
specifies the expansion, so no RFC doc edit was needed; the gate moves
from an #[ignore]'d unimplemented!() stub to a real integration test.

RFC0002.9 — real cross-alias test

Against a genuine RFC 0005 store (same fixture/store-builder the other
querier integration tests use):

• tenant T with rows for templates A, B, and a control C;
• an AliasMap built via the ourios-core operator API asserting B
  aliases A under T;
• resolves_to(A) matches both A and B, excludes C;
• template_id == A matches only A (the distinction is the point);
• resolves_to(B) is the same class (symmetry);
• the alias asserted under T does not leak to a second tenant T2
  (empty map): resolves_to(A) there matches only A's row (§3.7
  isolation).

Hazards

Hazard CLAUDE.md §4.6 (no DataFusion/arrow/SQL leakage): preserved.
AliasMap is an ourios-core type; the in_list is internal to the
compiler. The public run_query signature names only Ourios + std
types. §3.7 multi-tenancy: alias resolution is strictly per-tenant and
covered by the cross-tenant assertion.

Verification (local)

• cargo test --all-features — 534 passed; 0 failed; 41 ignored
  (RFC0002.9 + all RFC0002.x green; RFC0001.12–.16 green; whole
  workspace green)
• cargo fmt --all --check — clean
• cargo clippy --all-targets --all-features -- -D warnings — clean

Follow-up (flagged, not built)

How a querier process obtains the AliasMap in production (load /
snapshot / refresh of the physical map artifact) is the RFC 0005
physical-storage split, sibling to #147. This PR keeps the map an
injected in-memory projection.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@jensholdgaard, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 13 minutes and 5 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 777c54b5-755e-4c8e-9979-ca76943efd09

📥 Commits

Reviewing files that changed from the base of the PR and between 2e4704c and 16f7919.

📒 Files selected for processing (3)

• crates/ourios-querier/src/compile.rs
• crates/ourios-querier/src/lib.rs
• crates/ourios-querier/tests/rfc0002_dsl.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch slice-b-rfc0002-9-alias-expand

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jensholdgaard]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[Copilot]

Pull request overview

Wires the RFC 0001 per-tenant AliasMap into the querier’s DSL compilation so resolves_to(n) expands to the full alias equivalence class, and replaces the RFC0002.9 ignored stub with a real integration test covering cross-alias behavior.

Changes:

• Extend Querier::run_query to accept an injected &ourios_core::alias::AliasMap and thread it into compilation.
• Resolve resolves_to(n) at compile time into template_id IN (alias_class) via an eagerly collected alias-class map on the Plan.
• Flip RFC0002.9 from an ignored unimplemented!() to a real async integration test validating alias expansion.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
crates/ourios-querier/src/lib.rs	Adds alias_map parameter to run_query and forwards it into the compiler.
crates/ourios-querier/src/compile.rs	Collects alias classes at compile time and compiles resolves_to into an IN (...) filter.
crates/ourios-querier/tests/rfc0002_dsl.rs	Threads an empty alias map through existing tests and adds an RFC0002.9 integration test for alias expansion.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.