Skip to content

test(querier): RFC 0002 red gate — DSL acceptance stubs - #144

Merged
jensholdgaard merged 1 commit into
mainfrom
test/rfc0002-red-gate
Jun 7, 2026
Merged

test(querier): RFC 0002 red gate — DSL acceptance stubs#144
jensholdgaard merged 1 commit into
mainfrom
test/rfc0002-red-gate

Conversation

@jensholdgaard

Copy link
Copy Markdown
Owner

What

RFC 0002 red gate (query DSL specified → red, docs/verification.md §3 two-loop): 11 #[ignore]'d unimplemented!() stubs for the §5 acceptance criteria RFC0002.1–.11, each carrying the §2.2 doc-comment form (/// Scenario RFC0002.<n> — <title>. + /// See docs/rfcs/0002-query-dsl.md §5.) so the spec↔test mapping is greppable.

These front the already-implemented RFC 0007 §5 execution layer (predicate pushdown, tenant isolation, QueryStats — all green). The parser + compiler flip the stubs green in slices:

  1. predicate parser → query IR + structured surface → same IR (.1/.2/.7/.8)
  2. IR→DataFusion compile (internal Filter, no leakage) + default window + severity mapping + first-class fields (.3/.4/.5/.6)
  3. template primitives incl. resolves_to (.9)
  4. YAML-embeddability + structured JSON-schema validation (.10/.11)

Verification

  • cargo test -p ourios-querier --test rfc0002_dsl11 ignored (red gate). · cargo clippy --all-targets -- -D warnings ✓ · cargo fmt --all --check

🤖 Generated with Claude Code

@jensholdgaard
jensholdgaard requested a review from Copilot June 7, 2026 11:56
@jensholdgaard

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jensholdgaard, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 12 minutes and 48 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0693e980-6c10-4253-ab7d-de424f0f2e41

📥 Commits

Reviewing files that changed from the base of the PR and between acd6f1f and b7c6d47.

📒 Files selected for processing (1)
  • crates/ourios-querier/tests/rfc0002_dsl.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/rfc0002-red-gate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the RFC 0002 “Query DSL” red-gate acceptance test scaffolding to the ourios-querier crate, establishing a greppable mapping between RFC §5 acceptance criteria and (currently ignored) test stubs while the DSL parser/compiler work lands in later slices.

Changes:

  • Introduces an integration test file with 11 #[ignore]’d unimplemented!() stubs for scenarios RFC0002.1–RFC0002.11.
  • Adds module-level documentation describing the red-gate intent and how these stubs relate to the already-implemented RFC 0007 execution layer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Comment thread crates/ourios-querier/tests/rfc0002_dsl.rs Outdated
Red-gate step for the query DSL (RFC 0002 specified→red, docs/verification.md
§3 two-loop): 11 #[ignore]'d unimplemented!() stubs for RFC0002.1–.11, each
carrying the §2.2 doc-comment form (/// Scenario RFC0002.<n> — <title>. +
/// See `docs/rfcs/0002-query-dsl.md` §5.). The parser + compiler flip these
green in slices, fronting the implemented RFC 0007 §5 execution layer.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@jensholdgaard
jensholdgaard merged commit 3405048 into main Jun 7, 2026
11 checks passed
@jensholdgaard
jensholdgaard deleted the test/rfc0002-red-gate branch June 7, 2026 12:10
jensholdgaard added a commit that referenced this pull request Jun 7, 2026
…e blocker

Review: RFC 0002 status note now credits #143 (the spec PR) alongside
#144-#154; RFC 0007 §8 + the alternatives no longer say parser integration
is blocked on the RFC 0002 §3 branch decision (resolved, Branch B) — the
contradiction with the green status note is removed.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants