Fix tests for IPV6 #362
Merged
Fix tests for IPV6 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`plugin-pom` already contains a higher version than the one required and the override prevents it from being updated transitively on parent updates
Bump core version
car-roll
approved these changes
Apr 1, 2024
jglick
reviewed
Apr 5, 2024
| <jenkins.version>2.387.3</jenkins.version> | ||
| <!-- TODO until in plugin-pom --> | ||
| <jenkins-test-harness.version>2042.v787a_641a_9b_26</jenkins-test-harness.version> | ||
| <!-- TODO Until in plugin-pom --> |
There was a problem hiding this comment.
jenkinsci/plugin-pom#908 needs release apparently. Maybe we should switch to CD.
| @@ -109,9 +109,9 @@ private static void scriptExitingAcrossRestart1(JenkinsRule r) throws Throwable | |||
| var p = r.createProject(WorkflowJob.class, "p"); | |||
| var f = new File(r.jenkins.getRootDir(), "f"); | |||
| p.addProperty(new ParametersDefinitionProperty(new StringParameterDefinition("F"))); | |||
| p.setDefinition(new CpsFlowDefinition("node('remote') {if (isUnix()) {sh 'sleep 5 && touch \"$F\"'} else {bat 'ping -n 5 localhost && copy nul \"%F%\" && dir \"%F%\"'}}", true)); | |||
| p.setDefinition(new CpsFlowDefinition("node('remote') {if (isUnix()) {sh 'sleep 5 && touch \"$F\"'} else {bat 'ping -n 5 " + r.getURL().getHost() + " && copy nul \"%F%\" && dir \"%F%\"'}}", true)); | |||
There was a problem hiding this comment.
I guess; did you test this on Windows with IPv6?
There was a problem hiding this comment.
No, as I only had access to linux machines with IPv6 so I made sure it will not break any existing pr builder which uses ipv4 on windows and in case it breaks on windows with ipv6 for some reason we can fix later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the JTH version as I found that jenkinsci/jenkins-test-harness#712 was incomplete to make the tests on this plugin pass on an IPV6 env, so jenkinsci/jenkins-test-harness#742 was needed also.
I have also updated the core version to get https://issues.jenkins.io/browse/JENKINS-58041
I have not been able to test on windows, I hope the PR builder includes windows support, if not I will have to find someone with a windows machine willing to test this before mergePR builder includes windows tests, and my modifications to the windows specific section of theDurableTaskStepTestare passing see https://ci.jenkins.io/job/Plugins/job/workflow-durable-task-step-plugin/job/PR-362/1/testReport/org.jenkinsci.plugins.workflow.steps.durable_task/DurableTaskStepTest/Testing done
Run the PCT in a proprietary env with IPV6 support
mvn verifylocallySubmitter checklist