Adapt to IPV6 envs #742
Merged
Adapt to IPV6 envs #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usee `httpListenAddress` as default host There are no guarantees `localhost` is properly configured, specially in IPV6 environments
raul-arabaolaza
commented
Mar 27, 2024
| @@ -671,7 +671,7 @@ public URL getUrl() throws MalformedURLException { | |||
| if (port == 0) { | |||
| throw new IllegalStateException("This method must be called after calling #startJenkins."); | |||
| } | |||
| return new URL("http://" + host + ":" + port + "/jenkins/"); | |||
There was a problem hiding this comment.
This failed when host was an IPV6 ip
There was a problem hiding this comment.
I think this line was the only necessary change. The other change caused test regressions in other parts, so I'm proposing a revert of them in #776
raul-arabaolaza
changed the title
timja
approved these changes
Mar 27, 2024
rsandell
approved these changes
Mar 27, 2024
jtnord
approved these changes
Mar 27, 2024
jglick
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Looks right but @PereBueno why did this not come up during testing of #712?
Most likely system configuration. Some hosts/systems/OSes call Other hosts have 2 entries for |
Vlatombe
added a commit
to Vlatombe/jenkins-test-harness
that referenced
this pull request
May 31, 2024
Only leaves the relevant part which was to switch to the URL(String,String,String,String) constructor. The change from localhost to ip caused some test failures in Kubernetes context (It is invalid to provide an IP address as part of an ingress host name)
Vlatombe
added a commit
to Vlatombe/jenkins-test-harness
that referenced
this pull request
May 31, 2024
Reverts part of jenkinsci#742 Only leaves the relevant part which was to switch to the URL(String,String,String,String) constructor. The change from localhost to ip caused some test failures in Kubernetes context (It is invalid to provide an IP address as part of an ingress host name)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running
workflow-durable-task-steptests on a proprietary environment with only IPV6 networking enabled I found some parts of RJR that were not fully IPV6 compatible. This PR tries to fix those parts so RJR can be used in both IPV4 and IPV6 environments.Testing done
Submitter checklist