[RealJenkinsRule] Switching hardcoded IPv4 address to loopback address #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #711.
This change removes the hardcoded
127.0.0.1
address used inRealJenkinsRule
and replaces it with the real loopback address, so it will use the IPv4 loopback address, 127.0.0.1, or the IPv6 loopback address, ::1 (in long format, so 0:0:0:0:0:0:0:1).Regardless address can be overriden via
withHttpListenAddress
it makes sense to have default address use the right protocol so that method is used only for specific cases.This change won't affect any test using
getUrl()
method, as that method returns an URL pointing tolocalhost
so should be version-agnostic.Testing done
Check running tests using snapshot:
With IPv6
With IPv4
Submitter checklist