Various regressions from earlier code cleanup #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jan 3, 2020
| @@ -9,5 +9,9 @@ | |||
| /** | |||
| * Name of the cookie that stores HTTP session ID. | |||
| */ | |||
| public final static String SESSION_COOKIE_NAME = "JSESSIONID"; | |||
| // @SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "mutated by extras-executable-war") | |||
There was a problem hiding this comment.
#69 did not add the annotations JAR as a dep and I did not care to deal with that here. Anyway SB errors are not currently fatal.
timja
approved these changes
Jan 3, 2020
jeffret-b
approved these changes
Jan 3, 2020
jglick
added a commit
to jglick/jenkins
that referenced
this pull request
Jan 3, 2020
jglick
changed the title
|
By the way @oleg-nenashev ATH caught this after integration into Jenkins. |
|
Ack, thanks for fixing. It would be great to enable the integration testing everywhere :( |
|
Thanks for fixing the issues, also shoutouts to quality testing in ath
…On Sat, 4 Jan 2020, 6:21 AM Oleg Nenashev, ***@***.***> wrote:
Ack, thanks for fixing. It would be great to enable the integration
testing everywhere :(
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#86?email_source=notifications&email_token=AHPIYTCCDHFDOTAX6TC6DOTQ3626TA5CNFSM4KCR7PV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEICG6IA#issuecomment-570715936>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPIYTHTPRT4LOIV6TSLHSLQ3626TANCNFSM4KCR7PVQ>
.
|
oleg-nenashev
pushed a commit
to jenkinsci/jenkins
that referenced
this pull request
Jan 21, 2020
* Playing with WebSocket connections. * Pluggable handlers. * errorWithoutStack * Server-side keepalive pings. * Redesigned to work as an HttpResponse. * Unused dep. * Comment on JnlpSlaveRestarterInstaller. * Sketch of WebSocket-based endpoint for JNLPLauncher. * Comment. * Test enhancement. * Making it more obvious from JNLPLauncherTest where remoting.jar is being loaded from. * Reworked protocol to negotiate remote capabilities. * Unhelpful comment. * Simplifying handshake to use HTTP headers. * Moving code into top-level classes and otherwise prettifying. * Linking to upstream PRs. * Timestamped snapshot + incremental. * Picking up incrementalified build of winstone. * Working around jenkinsci/lib-access-modifier#17. * Finally have an incrementalified build of remoting. * Use -webSocket option. * Handling some close and error methods. * Sending X-Remoting-Minimum-Version. * If hudson.remoting.jnlp.Main._main fails, show the error. * Comment. * GUI analogue of jenkinsci/remoting@86cea5b. * Missing since tags. * Capitalization. * WebSockets.isSupported * Rather than hiding JNLPLauncher.DescriptorImpl when the TCP port is disabled, always display it, but show form validation appropriate to WebSocket or TCP mode. * Form validation fixes. * Minor test improvements. * Reworked WebSocketAgents to be compatible with JnlpAgentReceiver. * Removing WebSocketSession.keepAlive in favor of a global setting applicable to all services. * Add a -webSocket option to the Jenkins CLI. * Using a snapshot deployment of Remoting, pending INFRA-2379. * After #3838 there is no reason to recheck authentication after parsing CLICommand arguments. * Advertise the -webSocket option. * Adapt to newer HtmlUnit. * HtmlUnit/htmlunit#29 seems to have been incompatible. WebClient.addRequestHeader will no longer override a header in a WebRequest, such as when the same WebClient/WebRequest was previously used with different headers. * Tracked down a behavioral change in passing through URL-encoded path characters. HtmlUnit/htmlunit@2c49568 picks up apache/httpcomponents-client@8c04c6a which is the actual change. * Disabled TCP port does not matter in WebSocket mode. * Shade dependencies needed for jenkins-cli.jar. * Help text edit. * jenkinsci/winstone#79 was released as 5.5. * jenkinsci/jenkins-test-harness#183 released as 2.59. * #4387 (comment) * Bumping remoting to a new deployed snapshot. * Need jenkinsci/winstone#86. * jenkinsci/winstone#86 released as 5.6. * Introduced constant for X-Remoting-Minimum-Version. * s/slave/agent/ in GUI * Removing in-JVM test, as it was no longer useful after introducing shading anyway. * Bump. * No need to check for anonymous CONNECT here. * s/jenkins.slaves/jenkins.agents/g for new code. * Restrict the diagnostic endpoint to administrators. * Fixed Javadoc import after package move. * jenkinsci/remoting#357 released as 4.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects a regression from #69 found by @jeffret-b: jenkinsci/jenkins#4369 (comment)
See: https://github.com/jenkinsci/extras-executable-war/blob/2af94677c0ba557351d2c0703c3c43030c198b50/src/main/java/Main.java#L343-L371