Switch to spotbugs and fix some issues #69
Conversation
res0nance
commented
Aug 20, 2019
res0nance
commented
- Swapped to spotbugs and fixed multiple issues.
- There still remains some issues but the PR was getting large
|
Need to review it carefully, but thanks a lot! |
|
sorry, still in my queue |
| * @author mailto: <a href="[email protected]">Rick Knowles</a> | ||
| * @version $Id: Ajp13ConnectorFactory.java,v 1.12 2006/03/24 17:24:22 rickknowles Exp $ | ||
| */ | ||
| public class Ajp13ConnectorFactory implements ConnectorFactory { | ||
| public boolean start(Map args, Server server) throws IOException { | ||
| int listenPort = Option.AJP13_PORT.get(args); | ||
| String listenAddress = Option.AJP13_LISTEN_ADDRESS.get(args); | ||
| // String listenAddress = Option.AJP13_LISTEN_ADDRESS.get(args); |
There was a problem hiding this comment.
If unused, please.do one of the following..
- delete it
- Create a follow-up bug, link it from a TODO comment
Looks like it is a bug unless I miss something
| continue; | ||
| } | ||
| File parentOutFile = outFile.getParentFile(); | ||
| if (!parentOutFile.mkdirs()) { |
There was a problem hiding this comment.
We can drop Java 6 later and start using Files here.
CC @olamy
There was a problem hiding this comment.
I'll clean this bit up then
| public static OInt CONTROL_PORT = Option.integer("controlPort"); | ||
| public static OInt PORT = Option.integer("port"); | ||
| public static OInt DEBUG = new OInt("debug", 5) { | ||
| public final static OInt CONTROL_PORT = Option.integer("controlPort"); |
There was a problem hiding this comment.
IIRC breaking change was here. Not that important
| new String[][] {{"/", ""}, {"\\", ""}, {",", ""}}) + "/" : "") + | ||
| "winstone/" + warfile.getName()); | ||
| tempFile.delete(); | ||
| if (!tempFile.delete()) { |
There was a problem hiding this comment.
Or there is a Commons IO utility, or you can use java.nio.file.Files.delete which throws a meaningful exception.
| @@ -250,43 +254,52 @@ protected File getWebRoot(File requestedWebroot, File warfile) throws IOExceptio | |||
| if(!timestampFile.exists() || Math.abs(timestampFile.lastModified()- warfile.lastModified())>1000) { | |||
| // contents of the target directory is inconsistent from the war. | |||
| deleteRecursive(unzippedDir); | |||
| unzippedDir.mkdirs(); | |||
| if (!unzippedDir.mkdirs()) { | |||
| continue; | ||
| } | ||
| try { | ||
| Files.createDirectories(Paths.get(outFile.getParent())); |
There was a problem hiding this comment.
FWIW in Jenkins core we have been catching InvalidPathException as well, which apparently can happen under some obscure conditions on Windows servers.
There was a problem hiding this comment.
Would recommend to address it before merging
oleg-nenashev
changed the title
…no /embedded.war).
