[JEP-222] Add experimental WebSocket support + Jetty update in Winstone + Remoting 4.0

[jglick]

See JEP-222. Downstream of jenkinsci/winstone#79 + jenkinsci/remoting#357 + jenkinsci/jenkins-test-harness#183.

Proposed Changelog Entries

• Added experimental support for connecting inbound agents using a WebSocket transport over HTTP(S) rather than the TCP port, for easier network setup. See JEP-222 for details.
• Remoting 4.0 release, mostly to highlight the binary incompatibility in the last 3.x release: https://github.com/jenkinsci/remoting/releases/tag/remoting-4.0
• Jetty update in Winstone: https://github.com/jenkinsci/winstone/releases/tag/winstone-5.5

[jglick]

Looks like there are some test failures.

[jeffret-b]

So far I've just done a quick overview review. It looks good. It's well structured and easy to follow. I like how nicely it fits into the existing structure while providing valuable new capability.

I'll do a more thorough review at a later time.

[oleg-nenashev]

@jglick what is the rollout plan for this change? Do you want to have it as Beta in the next LTS or just as GA? It might be useful to put it into the JEP explicitly. Beta status would be nice in the changelog

[fcojfernandez]

I haven't tested it, but the code looks good

[jglick]

Do you want to have it as Beta in the next LTS or just as GA?

I do not think there is any formal mechanism for any such marking. We can phrase it as being experimental in the weekly changelog of course.

[oleg-nenashev]

I do not think there is any formal mechanism for any such marking. We can phrase it as being experimental in the weekly changelog of course.

Changelog would be enough. APIs are already marked as @Beta

[jglick]

APIs are already marked as @Beta

And could probably stay that way unless plugins start to want to implement their own endpoints.

[timja]

Haven't tested but code looks good

[oleg-nenashev]

requesting reviews from the @jenkinsci/core team since it is a major change under the hood of Jenkins. Unfortunately I do not have bandwidth to review it till the next week (wed or so), but I do not mind if it gets merged.with the current approvals.

@jglick Could you please also add the "collateral improvements" from Remoting and Winstone to the changelog?

• Major RFE: Remoting 4.0 release, mostly to highlight the binary incompatible in 4.0 and previous 3.x. https://github.com/jenkinsci/remoting/releases/tag/remoting-4.0
• RFE: Jetty update in Winstone 5.5: https://github.com/jenkinsci/winstone/releases/tag/winstone-5.5

[oleg-nenashev]

I plan to merge it tomorrow if no negative feedback

[jglick]

requesting reviews from the @jenkinsci/core team

Note that I already requested reviews from @jenkinsci/core-pr-reviewers.

[oleg-nenashev]

@jglick would you be interested to write a blog post about this new feature?

[jglick]

Yes I should be able to do that.

[jglick]

Merged toward 2.216 FTR.