Add Jenkinsfile to the repo#7
Conversation
|
|
||
| post { | ||
| always { | ||
| junit '*/target/surefire-reports/*.xml' |
There was a problem hiding this comment.
I would like to also publish FindBugs, but seems the publisher still does not support symbols
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Why not simply
buildPlugin()?
| // Make sure we have GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL set due to machine weirdness. | ||
| environment { | ||
| GIT_COMMITTER_NAME = "jenkins" | ||
| GIT_COMMITTER_EMAIL = "jenkins@jenkins.io" |
|
|
||
| post { | ||
| always { | ||
| junit '*/target/surefire-reports/*.xml' |
|
Yes, should be buildPlugin() . Or buildModule() just to have a planB for
the future
2017-02-27 16:58 GMT+01:00 Jesse Glick <notifications@github.com>:
… ***@***.**** commented on this pull request.
Why not simply
buildPlugin()
?
------------------------------
In Jenkinsfile
<#7 (comment)>
:
> +pipeline {
+ // Make sure that the tools we need are installed and on the path.
+ tools {
+ maven "mvn"
+ jdk "jdk8"
+ }
+
+ agent {
+ label "java"
+ }
+
+ // TODO: Copy-pasted from the Pipeline Model Definition example
+ // Make sure we have GIT_COMMITTER_NAME and GIT_COMMITTER_EMAIL set due to machine weirdness.
+ environment {
+ GIT_COMMITTER_NAME = "jenkins"
+ GIT_COMMITTER_EMAIL = ***@***.***"
What here is committing to Git?
------------------------------
In Jenkinsfile
<#7 (comment)>
:
> + environment {
+ GIT_COMMITTER_NAME = "jenkins"
+ GIT_COMMITTER_EMAIL = ***@***.***"
+ }
+
+ stages {
+ stage("build") {
+ steps {
+ sh 'mvn clean verify install -Dmaven.test.failure.ignore=true'
+ }
+ }
+ }
+
+ post {
+ always {
+ junit '*/target/surefire-reports/*.xml'
step
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC3IoHkh_EhIV9oQQ-Zek8mThILYgc63ks5rgvKygaJpZM4MNNGA>
.
|
|
@reviewbybees So I have created |
| @@ -0,0 +1,3 @@ | |||
|
|
|||
| // Builds a module using https://github.com/jenkins-infra/pipeline-library | |||
| buildModule(platforms: ['linux'], allowEmptyTestResults: true) | |||
There was a problem hiding this comment.
I would be more comfortable deleting
<disabledTestInjection>true</disabledTestInjection>| @@ -0,0 +1,3 @@ | |||
|
|
|||
| // Builds a module using https://github.com/jenkins-infra/pipeline-library | |||
There was a problem hiding this comment.
I think you can actually test the upstream PR prior to it being merged, using something like
@Library('github.com/oleg-nenashev/pipeline-library@7b106252928c000a81734f64eaa84f822a680134') _Of course this only matters if organization scanning is fixed while both PRs are open.
There was a problem hiding this comment.
For local testing I use jenkinsci/filesystem_scm-plugin#2.
For upstream PR testing I would like to get it hosted first :)
|
@jglick migrated to |
| <extensions>true</extensions> | ||
| <configuration> | ||
| <disabledTestInjection>true</disabledTestInjection> | ||
| <disabledTestInjection>false</disabledTestInjection> |
There was a problem hiding this comment.
Or just simply delete the whole plugin section, since you are not overriding anything any more.
|
@reviewbybees done. |
2 participants
This change adds Jenkinsfile for jenkins.io. I have not tested it (not sure how to reliably do it).
CC @rtyler and @reviewbybees