[WiP] - Change towards hosting modules on ci.jenkins.io#6
[WiP] - Change towards hosting modules on ci.jenkins.io#6oleg-nenashev wants to merge 3 commits into
Conversation
oleg-nenashev
changed the title
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
That is already supported with
This seems like a bad idea. You should always have |
| * `jenkinsVersions`: (default: `[null]`) - a matrix of Jenkins baseline versions to build/test against in parallel (null means default, | ||
| only available for Maven projects) | ||
| * `allowEmptyTestResults` (default: `false`) - Do not fail the build if the test results are missing. | ||
| It may be used for components, which have no tests within the repo |
There was a problem hiding this comment.
Delete comma. You are saying something grammatically valid but quite different than what I think you meant: “components have no tests, so you may use this flag for them” → “if you have a component which has no tests, then you may use this flag for it” (subtle point of English punctuation; I know at least Czech lacks this rule)
|
|
||
| def call(Map params = [:]) { | ||
| buildPlugin(params) | ||
| } No newline at end of file |
Maybe. But having a separate command is definitely reasonable for the future use
Not for the Jenkins module |
Well I disagree with that, but will leave it to the downstream PR. |
@oleg-nenashev would you mind adding some commentary into the |
|
@rtyler Let's put in on hold for a while. I really need to come-up with a realistic use-case for the Jenkins module lifecycle, but my previous ideas seem to be not really relevant since Jenkins modules are too close to plugins now. |
oleg-nenashev
changed the title
|
I'm going to close this out until we can figure out whether there's a strong use-case here. Feel free to re-open it if something comes up. |
3 participants
I work on the new release of the Windows Agent Installer Module, which currently has no active CI. So I would like to have a build flow defined by this lib. Downstream PR with Jenkinsfile: jenkinsci/windows-slave-installer-module#7
Changes:
buildModule()command. Now it is just a wrapper on the top ofbuildPlugin(), but it may change in the future (e.g. integration tests with the latest Jenkins core, etc.).allowEmptyTestResultsoption to bothbuildPlugin()andbuildModule()@reviewbybees, esp. @rtyler and @jglick