This repository was archived by the owner on May 14, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 24
Add Jenkinsfile to the repo #7
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6dd7c7b
Add Jenkinsfile to the repo
oleg-nenashev 594ba21
Migrate to the pipeline-library
oleg-nenashev 9575ce0
Allow empty test results (the first test is in another branch)
oleg-nenashev 30a79a9
Try buildPlugin() and enable the test injection
oleg-nenashev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
|
|
||
| // Builds a module using https://github.com/jenkins-infra/pipeline-library | ||
| buildPlugin(platforms: ['linux']) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,7 @@ | |
| <artifactId>maven-hpi-plugin</artifactId> | ||
| <extensions>true</extensions> | ||
| <configuration> | ||
| <disabledTestInjection>true</disabledTestInjection> | ||
| <disabledTestInjection>false</disabledTestInjection> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Or just simply delete the whole plugin section, since you are not overriding anything any more. |
||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can actually test the upstream PR prior to it being merged, using something like
Of course this only matters if organization scanning is fixed while both PRs are open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For local testing I use jenkinsci/filesystem_scm-plugin#2.
For upstream PR testing I would like to get it hosted first :)