Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to customize number of suggestions in autocomplete #9616

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Aug 15, 2024

Follow-up for #9453 allowing the number of shown suggestions to be customized.
This should allow removal of YUI from appscan plugin (draft PR jenkinsci/appscan-plugin#226 ).

Part of https://issues.jenkins.io/browse/JENKINS-73539 epic.

Testing done

Manually verified that autocomplete with data-maxsuggestions=9999 shows many suggestions in a scrollable popup.

Proposed changelog entries

  • Allow plugins to customize maximum number of suggestions in autocomplete text fields.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mawinter69

Before the changes are marked as ready-for-merge:

Maintainer checklist

@NotMyFault NotMyFault added the developer Changes which impact plugin developers label Aug 15, 2024
@NotMyFault NotMyFault requested a review from a team August 15, 2024 14:33
@timja
Copy link
Member

timja commented Aug 15, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 15, 2024
@NotMyFault NotMyFault merged commit 94aadfc into jenkinsci:master Aug 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants