Make dependency on YUI optional #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattmurp will you have time to review this? |
mattmurp
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin customized autocomplete text fields that have been replaced in Jenkins 2.473 as part of larger effort to remove the YUI library from Jenkins (see https://issues.jenkins.io/browse/JENKINS-73539).
The new autocomple text fields will support the same customization when jenkinsci/jenkins#9616 is merged.
This PR makes sure the plugin will still work with YUI removed and that the right number of suggestions will be shown in new versions of Jenkins.
Testing done
None, I don't have any account for AppScan. I would appreciate if the maintainers would check that autocomplete fields still work properly.
Submitter checklist