Use standard dropdowns for autocomplete

[zbynek]

Further reduces usage of YUI by switching autocomplete fields to the dropdown component.

Screenshots

Before

After

Testing done

Manual testing with the job trigger for freestyle jobs (see screenshot)

No automated tests -- this could be only covered by UI tests and I'm not sure those would be worth adding/maintaining.

Proposed changelog entries

• Use dropdown component for autocomplete fields (instead of YUI framework).

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

LGTM worked in testing on a freestyle project and on the design library

[janfaracik]

Looks good to me - any thoughts on making the dropdown full width?

[zbynek]

any thoughts on making the dropdown full width?

I don't have a preference. @timja @NotMyFault WDYT?

[timja]

any thoughts on making the dropdown full width?

I don't have a preference. @timja @NotMyFault WDYT?

is that after or before?

[zbynek]

The last screenshot is potential after (not implemented), screenshot of the current implementation is in the PR description.

[timja]

Current one is cut-off though so can't really see the impact of the change unless I'm misunderstanding

[zbynek]

Without cutoff:

The upside is that with more suggestions the narrow popup covers fewer UI elements, the downside is that validation of partial input may be visible below (as shown in the screenshot in description).

[timja]

Ah I see, I think full width is better but no strong preference

[zbynek]

Full width pushed, this is now ready from my side, thanks for the feedback.

[daniel-beck]

This unfavorably interacts with browser built-in autocompletion based on form history.

new.mov

old.mov

Additionally, it seems error-prone and bad UX for the popup to close when you click inside the form field, rather than staying open.

[zbynek]

@daniel-beck thanks for pointing those out, both fixed in the last commit

[mawinter69]

I created JENKINS-73562 to track the removal of YUI from autocomplete

[zbynek]

@daniel-beck will you have time to check if my last changes address the issues you mentioned?

[daniel-beck]

The current state addresses both previous issues I've identified.

[timja]

@daniel-beck does this still need a security review?

[daniel-beck]

@timja Thanks, forgot.

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!